TypeScript icon indicating copy to clipboard operation
TypeScript copied to clipboard

fix first match in `RegExpMatchArray` being possibly undefined when `noUncheckedIndexedAccess` is enabled

Open DetachHead opened this issue 3 years ago • 5 comments

Fixes #42296

DetachHead avatar Jun 26 '22 04:06 DetachHead

The TypeScript team hasn't accepted the linked issue #42296. If you can get it accepted, this PR will have a better chance of being reviewed.

typescript-bot avatar Jun 26 '22 09:06 typescript-bot

@typescript-bot run dt @typescript-bot user test this

sandersn avatar Jul 06 '22 23:07 sandersn

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 93e0cfe3c10a51c90f87573bcaf1a4f260c55495. You can monitor the build here.

Update: The results are in!

typescript-bot avatar Jul 06 '22 23:07 typescript-bot

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 93e0cfe3c10a51c90f87573bcaf1a4f260c55495. You can monitor the build here.

typescript-bot avatar Jul 06 '22 23:07 typescript-bot

@sandersn Great news! no new errors were found between main..refs/pull/49682/merge

typescript-bot avatar Jul 06 '22 23:07 typescript-bot