TypeScript-Node-Starter icon indicating copy to clipboard operation
TypeScript-Node-Starter copied to clipboard

removed chai and replaced it totally with jest

Open nishat-sayyed opened this issue 4 years ago • 3 comments

The chai testing framework is not required as Jest comes bundled with expect and other utility methods.

Following two files were using chai

  1. user.test.ts
  2. contact.test.ts

Also removed chai from package.json and added "include": ["src/**/*", "test/**/*"] in tsconfig.json to support Typescript in the test directory.

All test cases are passing after the change as you can see in the attachment image

nishat-sayyed avatar May 13 '20 09:05 nishat-sayyed

CLA assistant check
All CLA requirements met.

msftclas avatar May 13 '20 09:05 msftclas

Can you, please, revert changes with white-space applied? It looks the semicolons were removed as well, not only unifiying the spaces. See ESLint config:

"semi": ["error", "always"], "quotes": ["error", "double"],

Not sure why it fails on CI, for me it works OK locallly. You could automate fix with package:

npm run lint

peterblazejewicz avatar May 14 '20 20:05 peterblazejewicz

Thanks @peterblazejewicz I'll try that once I am free.

nishat-sayyed avatar Nov 04 '20 18:11 nishat-sayyed