Forked and created a REST API starter

[ghost]

Hi guys, I've forked this awesome starter project and created a starter for a REST API: TypeScript REST Node Starter
It has a basic JWT authentication and activation using SMTP without passport. It needs improvements (Swagger integration, tests, password expiry handling, and general code improvements).
My question is should we, after needed improvements, at some point create a pull request on a new branch of this project where i think that code belongs?
I would appreciate if someone can review and advise, thanks!

[myarete]

@maljukan Can you enable issues on your repo? Definitely would like to follow that one :)

[ghost]

@MrChristofferson Done, started an avalanche i guess :D

[mattwelke]

Thanks for letting us know. I like the idea of keeping this repo agnostic, showing how to build a Node app but not leaning towards a specific type of app. Now that we have that REST starter, it can evolve separately.

[bowdenk7]

This is great! I'll try to review it if I get some spare time.

I'm not sure branches are very discoverable, so I think a separate repo with links from this repo's README will be best. That said, I have no problem doing both :)

[ghost]

Thanks @bowdenk7 and thanks for your support guys. I used this thread a counseling about the way to go. At the moment i'm having so many doubts and i can't go further until i get some feedback from the community.

• For instance, for now i resisted the urge to introduce decorators (although i don't like how routes are mapped to controllers), as i aim to keep things simple and working and get some feedback that'll light up the way to go.
• I didn't introduce passport as i would like to get some PROS and CONS against current way of handling the Authentication and Authorization.
• Also i would like to find out weather it's better to keep using Active Directory way of handling the models or should we go for Repository pattern.

Feel free to close this issue and to open issues on the fork.