TypeScript-DOM-lib-generator icon indicating copy to clipboard operation
TypeScript-DOM-lib-generator copied to clipboard
verified publisher icon microsoft

Remove StyleMedia

Open Bashamega opened this issue 2 months ago • 6 comments

Can you test this @jakebailey ? Sorry for the late PR, I was busy

Bashamega avatar Oct 20 '25 10:10 Bashamega

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

github-actions[bot] avatar Oct 20 '25 10:10 github-actions[bot]

This is removing StyleMedia not StylePropertyMap, please change the title

saschanaz avatar Oct 20 '25 11:10 saschanaz

React v15 is still using this, it seems. Probably not worth removing?

jakebailey avatar Oct 21 '25 02:10 jakebailey

Yeah, we should try adding it to DT and maybe revisit this later

saschanaz avatar Oct 21 '25 05:10 saschanaz

Can you try to test this since the definitely typed PR was merged? @jakebailey

Bashamega avatar Nov 03 '25 17:11 Bashamega

https://github.com/microsoft/TypeScript/pull/62640 is happy on DT, but causes very odd test failures elsewhere that I need to investigate.

jakebailey avatar Nov 03 '25 19:11 jakebailey

Hello @jakebailey Did you have time to see why it was failing?

Bashamega avatar Dec 24 '25 05:12 Bashamega

I think we just are waiting for some time for people to adopt the DT side change

saschanaz avatar Dec 24 '25 12:12 saschanaz