TypeScript-DOM-lib-generator icon indicating copy to clipboard operation
TypeScript-DOM-lib-generator copied to clipboard

NotificationOptions is missing actions option

Open TheNoim opened this issue 1 year ago • 5 comments
trafficstars

Hey,

I noticed that the NotificationOptions definition doesn't include the actions option. This is the current definition: dom.generated.d.ts and serviceworker.generated.d.ts

Here is the relevant mdn link.

In addition, timestamp and renotify are also missing.

This might be an regression of #438, but I am not sure.

TheNoim avatar May 13 '24 08:05 TheNoim

https://github.com/microsoft/TypeScript-DOM-lib-generator?tab=readme-ov-file#when-the-type-is-missing

If there is, see the browser compatibility section and check whether it's supported by two or more browser engines. (Note that Chromium-based browsers use the same browser engine and thus support from them counts as a single support.)

So your suggestion is missing Firefox or Safari support.

HolgerJeromin avatar May 13 '24 15:05 HolgerJeromin

As mentioned by @TheNoim, timestamp has been removed without any documentation on MDN suggesting lack of support.

benelliott avatar May 30 '24 13:05 benelliott

So your suggestion is missing Firefox or Safari support.

requireInteraction is included and has the same support as actions

markusahrweileramcon avatar Jun 28 '24 06:06 markusahrweileramcon

Is there any update on this?

IgnisDa avatar Sep 28 '24 18:09 IgnisDa

Looking for an update on this as well.

tappin-kr avatar Oct 03 '24 20:10 tappin-kr

Is this issue being worked? We use actions in our code base and they work perfectly fine. It's annoying that typescript thinks there is an error. Our payload looks similar to this:

{
    body: '',
    actions: [], //Typescript error
    data: {}
}

snotmare avatar Jan 22 '25 13:01 snotmare

also vibrate

zdila avatar Apr 30 '25 12:04 zdila

Still not enough support

Bashamega avatar May 13 '25 08:05 Bashamega