TypeScript-DOM-lib-generator icon indicating copy to clipboard operation
TypeScript-DOM-lib-generator copied to clipboard

`RtcRtpEncodingParameters.maxFramerate` not included

Open nainkunal933 opened this issue 1 year ago • 1 comments

Hi,

As I was going through the definitions, it seems like in Typescript 4.3 or @types/[email protected] maxFramerate was not included. At the time, it looks like maxFramerate did not have enough support among multiple browsers. Since then, the browser support has increased sufficiently: https://developer.mozilla.org/en-US/docs/Web/API/RTCRtpEncodingParameters/maxFramerate.

I went through the contribution guidelines and confirmed that maxFramerate is not included in inputfiles/removedTypes.jsonc. The exclusion of maxFramerate is a breaking change for us. There is another instance of this being a breaking change: https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/991#issuecomment-864454049 for another dev.

I will like to know if maxFramerate can be added back to the types?

nainkunal933 avatar Aug 17 '22 22:08 nainkunal933

This is because people are not sure it's interop-ready: https://github.com/w3c/webrtc-extensions/issues/108

That said, the implementation detail doesn't matter for TypeScript. I'll accept a PR for this.

saschanaz avatar Sep 18 '22 12:09 saschanaz