TemplateStudio icon indicating copy to clipboard operation
TemplateStudio copied to clipboard

[WIP] change RuntimeIdentifier to win-xxx for .NET 8.0 -- fix issue #4717

Open tonymet opened this issue 1 year ago • 4 comments

PR checklist

Quick summary of changes Fix .NET 8.0 specified RuntimeIdentifier 'win10-x64' is not recognized.

Full Error

NETSDK1083	The specified RuntimeIdentifier 'win10-x64' is not recognized. See https://aka.ms/netsdk1083 for more information.

More info: https://learn.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/8.0/runtimeidentifier

Steps to Repeat

  1. Create new project from template
  2. Build Project

Which issue does this PR relate to?

#4717

Applies to the following platforms

  • [✅ ] WinUI
  • [ ] WPF
  • [ ] UWP

Anything that requires particular review or attention?

  • I could use help on how to perform e2e test with Template Studio using the updated template from this branch.
  • how to test this with earlier versions of .net e.g. .net 7 , .net 6
  • how to run automation on my own.

Do all automated tests pass?

✅ yes

Have automated tests been added for new features? N/A

If you've changed the UI: n/a

If you've included a new template: n/a

Have you raised issues for any needed follow-on work? n/a

Have docs been updated? no

If breaking changes or different ways of doing things have been introduced, have they been communicated widely?

tonymet avatar Dec 11 '23 23:12 tonymet

I was able to get this working locally by adding this to my csproj

<UseRidGraph>true</UseRidGraph>
<RuntimeIdentifiers>win10-x86;win10-x64;win10-arm64</RuntimeIdentifiers>

licon4812 avatar Dec 25 '23 21:12 licon4812

Thahks for this. @licon4812 is correct. I am planning to use <UseRidGraph>true</UseRidGraph> for maximum backward compatibility for the next release. You can close this PR or change to use Rid

pratikone avatar Mar 26 '24 23:03 pratikone

can you clarify? has it been fixed?

tonymet avatar Mar 27 '24 01:03 tonymet

not yet. I am suggesting to use <UseRidGraph>true</UseRidGraph> in your PR instead of win-x64 values so that it is backward compatible and then lets merge it UseRidGraph>true</UseRidGraph> <RuntimeIdentifiers>win10-x86;win10-x64;win10-arm64</RuntimeIdentifiers>

pratikone avatar Apr 04 '24 08:04 pratikone