TemplateStudio icon indicating copy to clipboard operation
TemplateStudio copied to clipboard

Refactor UpdateTitleBar method

Open humbertomoli99 opened this issue 1 year ago • 1 comments

PR checklist

Quick summary of changes Removed redundant assignment and simplified theme assignment logic. Also, eliminated unnecessary variables.

Which issue does this PR relate to?

Applies to the following platforms:

  • [x] WinUI
  • [ ] WPF
  • [ ] UWP

Anything that requires particular review or attention? delete comment issues/4516 is neccesary (TitleBarHelper.cs)

Do all automated tests pass?

Have automated tests been added for new features?

If you've changed the UI:

  • Be sure you are including screenshots to show the changes.
  • Be sure you have reviewed the accessibility checklist.

If you've included a new template:

Have you raised issues for any needed follow-on work?

Have docs been updated?

If breaking changes or different ways of doing things have been introduced, have they been communicated widely?

humbertomoli99 avatar May 31 '23 09:05 humbertomoli99

thanks for sharing that. I do understand that logic has a lot of redundancies and I am waiting for appwindow titlebar merger to do a cleanup. However, that piece of code is necessary. There is a difference between RequestedTheme and "applied theme". so the current applied theme will not be reflected if we only keep code for requested theme. Still, that is a good approach. More eyes on these kind of opportunities and we will have a good tidy codebase. Thanks for doing it

pratikone avatar Jun 06 '23 17:06 pratikone