TemplateStudio icon indicating copy to clipboard operation
TemplateStudio copied to clipboard

Uri Scheme could have a hidden page

Open mvegaca opened this issue 6 years ago • 6 comments

I think that the activation page added by UriScheme feature could be a ActivationPage dependency and ActivationPage could be a BlankPage or a specific hidden page. We currently have a similar situation with SampleDataService

mvegaca avatar Sep 18 '17 10:09 mvegaca

Is there another feature that would use this?

mrlacey avatar Sep 18 '17 10:09 mrlacey

I think that ActivationPage probably makes sense to add to other future activation features, but it does not matter, maybe it makes sense that if we handle the concept of pages and features, and this feature adds to that page you can see that page on the summary as a hidden and non removable page.

This issue is not a bug, is only a open question about a feature that is including a page.

mvegaca avatar Sep 18 '17 10:09 mvegaca

If and when we have other features/pages that do something similar it may make sense to refactor what we've already got. To do it now is more work for no benefit. Definitely not something that needs doing for 1.4

mrlacey avatar Sep 18 '17 11:09 mrlacey

I agree on this is low priority

mvegaca avatar Sep 18 '17 12:09 mvegaca

Agree, moving it to backlog.

ralarcon avatar Sep 18 '17 12:09 ralarcon

It looks like this was implemented as part of #2542 @mvegaca can you can confirm? Then close if appropriate or update with further actions/requirements.

mrlacey avatar Jan 08 '19 13:01 mrlacey