SynapseML
SynapseML copied to clipboard
fix: don't hard-code spark version when creating SJDs
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Record spark version in BuildInfo and then use that when creating SJD for E2E tests
How is this patch tested?
partially tested locally; rest will be in PR build
- [ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.
Does this PR change any dependencies?
- [x] No. You can skip this section.
- [ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.
Does this PR add a new feature? If so, have you added samples on website?
- [x] No. You can skip this section.
- [ ] Yes. Make sure you have added samples following below steps.
- Find the corresponding markdown file for your new feature in
website/docs/documentation
folder. Make sure you choose the correct classestimators/transformers
and namespace. - Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
- Make sure the
DocTable
points to correct API link. - Navigate to website folder, and run
yarn run start
to make sure the website renders correctly. - Don't forget to add
<!--pytest-codeblocks:cont-->
before each python code blocks to enable auto-tests for python samples. - Make sure the
WebsiteSamplesTests
job pass in the pipeline.
Hey @niehaus59 :wave:! Thank you so much for contributing to our repository :raised_hands:. Someone from SynapseML Team will be reviewing this pull request soon.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!
Examples of commit messages with semantic prefixes:
-
fix: Fix LightGBM crashes with empty partitions
-
feat: Make HTTP on Spark back-offs configurable
-
docs: Update Spark Serving usage
-
build: Add codecov support
-
perf: improve LightGBM memory usage
-
refactor: make python code generation rely on classes
-
style: Remove nulls from CNTKModel
-
test: Add test coverage for CNTKModel
To test your commit locally, please follow our guild on building from source. Check out the developer guide for additional guidance on testing your change.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Codecov Report
Merging #2101 (65dbe59) into master (2abfbda) will decrease coverage by
2.79%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #2101 +/- ##
==========================================
- Coverage 86.25% 83.47% -2.79%
==========================================
Files 310 310
Lines 16254 16254
Branches 818 818
==========================================
- Hits 14020 13568 -452
- Misses 2234 2686 +452
/azp run
Azure Pipelines successfully started running 1 pipeline(s).