SynapseML icon indicating copy to clipboard operation
SynapseML copied to clipboard

do not merge: move dependencies to databricks utils

Open imatiach-msft opened this issue 2 years ago • 8 comments
trafficstars

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

move dependencies to databricks utils

How is this patch tested?

  • [x] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • [ ] No. You can skip this section.
  • [x] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • [x] No. You can skip this section.
  • [ ] Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder. Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

imatiach-msft avatar Jun 07 '23 02:06 imatiach-msft

Hey @imatiach-msft :wave:! Thank you so much for contributing to our repository :raised_hands:. Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source. Check out the developer guide for additional guidance on testing your change.

github-actions[bot] avatar Jun 07 '23 02:06 github-actions[bot]

/azp run

imatiach-msft avatar Jun 07 '23 02:06 imatiach-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 07 '23 02:06 azure-pipelines[bot]

Codecov Report

Merging #1980 (dca6b66) into master (fc5d699) will decrease coverage by 7.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1980      +/-   ##
==========================================
- Coverage   87.02%   79.99%   -7.03%     
==========================================
  Files         305      305              
  Lines       15993    15993              
  Branches      839      839              
==========================================
- Hits        13918    12794    -1124     
- Misses       2075     3199    +1124     

see 39 files with indirect coverage changes

codecov-commenter avatar Jun 07 '23 02:06 codecov-commenter

/azp run

imatiach-msft avatar Jun 07 '23 21:06 imatiach-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 07 '23 21:06 azure-pipelines[bot]

/azp run

imatiach-msft avatar Jun 08 '23 15:06 imatiach-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 08 '23 15:06 azure-pipelines[bot]