SynapseML icon indicating copy to clipboard operation
SynapseML copied to clipboard

feat: Add refreshAADToken and SynapsePlatformUtils for internal usage

Open serena-ruan opened this issue 2 years ago • 12 comments

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • [ ] I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • [ ] No. You can skip this section.
  • [ ] Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • [ ] No. You can skip this section.
  • [ ] Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder. Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

serena-ruan avatar Feb 23 '23 08:02 serena-ruan

Hey @serena-ruan :wave:! Thank you so much for contributing to our repository :raised_hands:. Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source. Check out the developer guide for additional guidance on testing your change.

github-actions[bot] avatar Feb 23 '23 08:02 github-actions[bot]

/azp run

serena-ruan avatar Feb 23 '23 08:02 serena-ruan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 23 '23 08:02 azure-pipelines[bot]

Codecov Report

Merging #1845 (b257219) into master (1b71c1d) will decrease coverage by 0.13%. The diff coverage is 24.39%.

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
- Coverage   86.71%   86.59%   -0.13%     
==========================================
  Files         301      302       +1     
  Lines       15622    15660      +38     
  Branches      813      796      -17     
==========================================
+ Hits        13547    13560      +13     
- Misses       2075     2100      +25     
Impacted Files Coverage Δ
...e/synapse/ml/core/utils/SynapsePlatformUtils.scala 20.00% <20.00%> (ø)
...re/synapse/ml/cognitive/CognitiveServiceBase.scala 78.86% <36.36%> (-2.86%) :arrow_down:

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Feb 23 '23 09:02 codecov-commenter

/azp run

serena-ruan avatar Feb 24 '23 05:02 serena-ruan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 24 '23 05:02 azure-pipelines[bot]

/azp run

serena-ruan avatar Feb 24 '23 07:02 serena-ruan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 24 '23 07:02 azure-pipelines[bot]

/azp run

serena-ruan avatar Apr 17 '23 14:04 serena-ruan

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Apr 17 '23 14:04 azure-pipelines[bot]

/azp run

serena-ruan avatar Apr 20 '23 05:04 serena-ruan

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 20 '23 05:04 azure-pipelines[bot]