SynapseML icon indicating copy to clipboard operation
SynapseML copied to clipboard

Log async call duration and include final status in retries exceeded error

Open stuartleeks opened this issue 2 years ago • 7 comments

  • Add setAsyncCompletionLogMessagePrefixValue to enable logging of async operations on completion (with duration)
  • When reporting the retries exceeded error, include the last retrieved status to aid debugging

stuartleeks avatar Jan 17 '22 13:01 stuartleeks

/azp run

stuartleeks avatar Jan 18 '22 11:01 stuartleeks

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 18 '22 11:01 azure-pipelines[bot]

Codecov Report

Merging #1349 (c5a7863) into master (2c1a0fb) will decrease coverage by 0.02%. The diff coverage is 58.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
- Coverage   84.80%   84.77%   -0.03%     
==========================================
  Files         287      287              
  Lines       14231    14249      +18     
  Branches      732      726       -6     
==========================================
+ Hits        12068    12079      +11     
- Misses       2163     2170       +7     
Impacted Files Coverage Δ
...zure/synapse/ml/cognitive/DocumentTranslator.scala 19.44% <0.00%> (-0.28%) :arrow_down:
.../azure/synapse/ml/geospatial/AzureMapsTraits.scala 60.65% <56.25%> (+0.65%) :arrow_up:
...ft/azure/synapse/ml/cognitive/ComputerVision.scala 72.76% <61.90%> (-0.28%) :arrow_down:
...se/ml/cognitive/MultivariateAnomalyDetection.scala 87.33% <75.00%> (-1.05%) :arrow_down:
...zure/synapse/ml/stages/PartitionConsolidator.scala 95.74% <0.00%> (+2.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c1a0fb...c5a7863. Read the comment docs.

codecov-commenter avatar Jan 18 '22 11:01 codecov-commenter

@mhamilton723 - I've just pushed a new commit that simplifies the approach in the PR based on my understanding of our conversation

stuartleeks avatar Jan 20 '22 16:01 stuartleeks

/azp run

stuartleeks avatar Jan 20 '22 16:01 stuartleeks

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 20 '22 16:01 azure-pipelines[bot]

@mhamilton723 - are you able to review this?

stuartleeks avatar Feb 08 '22 11:02 stuartleeks