SynapseML icon indicating copy to clipboard operation
SynapseML copied to clipboard

is the unit tests reproducible on my personal computer?

Open luoguohao opened this issue 3 years ago • 2 comments

Describe the bug is there anyone tried to build mmlspark on your own desktop ? some unit tests could not pass for the LightGBM modules, such as com.microsoft.ml.spark.lightgbm.split1.VerifyLightGBMClassifier#"Verify LightGBM Classifier with validation dataset",i just wondering whether the unit test is reproducible?

To Reproduce

Expected behavior

Info (please complete the following information):

  • SynapseML Version: [v0.18.1]
  • Spark Version [2.4.3]

luoguohao avatar Dec 30 '21 11:12 luoguohao

@luoguohao Sorry about the trouble you are having. That specific test, with the validation dataset, has a history of failing a lot in the past and can be quite flaky. I'm open to any suggestions for how that test can be improved - it is basically just validating that early stopping is working correctly. Please ignore it if it is failing on your personal machine.

imatiach-msft avatar Dec 30 '21 16:12 imatiach-msft

thx for responding such fast, i just ignore the weird unit tests, not only the 'validation test'.

luoguohao avatar Dec 31 '21 09:12 luoguohao