SynapseML
SynapseML copied to clipboard
fix: activateCondaEnv on Linux
The activateCondaEnv command works on Windows but returns an empty Seq() for other OS's.
As a consequence when running, for example, installPipPackage on Linux the Python wheels are installed under the base conda environment and not synapseml. Also, when running testPython there are some errors such as
~/anaconda3/bin/python: No module named pytest
With this fix activateCondaEnv will also work on Linux using conda run (as the comment in the code suggests, running conda activate fails).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Codecov Report
Merging #1303 (75fc8e9) into master (2c1a0fb) will increase coverage by
0.05%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #1303 +/- ##
==========================================
+ Coverage 84.70% 84.76% +0.05%
==========================================
Files 287 280 -7
Lines 14231 14096 -135
Branches 732 732
==========================================
- Hits 12055 11948 -107
+ Misses 2176 2148 -28
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...org/apache/spark/ml/param/JsonEncodableParam.scala | 53.33% <0.00%> (-26.67%) |
:arrow_down: |
| ...g/apache/spark/ml/param/PythonWrappableParam.scala | 66.66% <0.00%> (-8.34%) |
:arrow_down: |
| ...soft/azure/synapse/ml/cognitive/TextToSpeech.scala | 84.84% <0.00%> (-3.04%) |
:arrow_down: |
| ...oft/azure/synapse/ml/cognitive/TextAnalytics.scala | 85.82% <0.00%> (-2.69%) |
:arrow_down: |
| .../azure/synapse/ml/cognitive/TextAnalyticsSDK.scala | 86.01% <0.00%> (-1.40%) |
:arrow_down: |
| ...ft/azure/synapse/ml/cognitive/FormRecognizer.scala | 81.00% <0.00%> (-1.00%) |
:arrow_down: |
| ...t/azure/synapse/ml/cognitive/BingImageSearch.scala | 89.28% <0.00%> (-0.90%) |
:arrow_down: |
| ...python/synapse/ml/io/http/SimpleHTTPTransformer.py | ||
| ...main/python/synapse/ml/io/http/ServingFunctions.py | ||
| ...main/python/synapse/ml/io/http/JSONOutputParser.py | ||
| ... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2c1a0fb...75fc8e9. Read the comment docs.
Commenter does not have sufficient privileges for PR 1303 in repo microsoft/SynapseML
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Commenter does not have sufficient privileges for PR 1303 in repo microsoft/SynapseML
/azp run
Azure Pipelines successfully started running 1 pipeline(s).