SynapseML icon indicating copy to clipboard operation
SynapseML copied to clipboard

fix: activateCondaEnv on Linux

Open luisffranca opened this issue 3 years ago • 10 comments

The activateCondaEnv command works on Windows but returns an empty Seq() for other OS's.

As a consequence when running, for example, installPipPackage on Linux the Python wheels are installed under the base conda environment and not synapseml. Also, when running testPython there are some errors such as

~/anaconda3/bin/python: No module named pytest

With this fix activateCondaEnv will also work on Linux using conda run (as the comment in the code suggests, running conda activate fails).

luisffranca avatar Dec 10 '21 14:12 luisffranca

/azp run

mhamilton723 avatar Dec 10 '21 20:12 mhamilton723

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 10 '21 20:12 azure-pipelines[bot]

Codecov Report

Merging #1303 (75fc8e9) into master (2c1a0fb) will increase coverage by 0.05%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   84.70%   84.76%   +0.05%     
==========================================
  Files         287      280       -7     
  Lines       14231    14096     -135     
  Branches      732      732              
==========================================
- Hits        12055    11948     -107     
+ Misses       2176     2148      -28     
Impacted Files Coverage Δ
...org/apache/spark/ml/param/JsonEncodableParam.scala 53.33% <0.00%> (-26.67%) :arrow_down:
...g/apache/spark/ml/param/PythonWrappableParam.scala 66.66% <0.00%> (-8.34%) :arrow_down:
...soft/azure/synapse/ml/cognitive/TextToSpeech.scala 84.84% <0.00%> (-3.04%) :arrow_down:
...oft/azure/synapse/ml/cognitive/TextAnalytics.scala 85.82% <0.00%> (-2.69%) :arrow_down:
.../azure/synapse/ml/cognitive/TextAnalyticsSDK.scala 86.01% <0.00%> (-1.40%) :arrow_down:
...ft/azure/synapse/ml/cognitive/FormRecognizer.scala 81.00% <0.00%> (-1.00%) :arrow_down:
...t/azure/synapse/ml/cognitive/BingImageSearch.scala 89.28% <0.00%> (-0.90%) :arrow_down:
...python/synapse/ml/io/http/SimpleHTTPTransformer.py
...main/python/synapse/ml/io/http/ServingFunctions.py
...main/python/synapse/ml/io/http/JSONOutputParser.py
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c1a0fb...75fc8e9. Read the comment docs.

codecov-commenter avatar Dec 10 '21 20:12 codecov-commenter

Commenter does not have sufficient privileges for PR 1303 in repo microsoft/SynapseML

azure-pipelines[bot] avatar Jan 13 '22 16:01 azure-pipelines[bot]

/azp run

imatiach-msft avatar Jan 18 '22 14:01 imatiach-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 18 '22 14:01 azure-pipelines[bot]

/azp run

luisffranca avatar Jan 19 '22 15:01 luisffranca

Commenter does not have sufficient privileges for PR 1303 in repo microsoft/SynapseML

azure-pipelines[bot] avatar Jan 19 '22 15:01 azure-pipelines[bot]

/azp run

imatiach-msft avatar Jan 19 '22 15:01 imatiach-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 19 '22 15:01 azure-pipelines[bot]