SandDance icon indicating copy to clipboard operation
SandDance copied to clipboard

SandDance Explorer Dark Mode

Open praveen5959 opened this issue 3 years ago • 2 comments

On the Demo page I can see that there is Dark Mode but when I spin up sample React application of SandDance Explorer package there is no theme change button. image

Any idea why this feature is not enabled for me?

praveen5959 avatar Nov 12 '21 15:11 praveen5959

Hello @praveen5959 , the rationale is that sanddance-explorer is a component that can be embedded within any app or page, and we can't assume that the container has theming, or already has its own theme mechanism. So you must access it programmatically. See: https://github.com/microsoft/SandDance/blob/master/packages/sanddance-explorer/src/themes.ts https://github.com/microsoft/SandDance/blob/master/packages/sanddance-app/src/sanddanceApp.tsx#L217

danmarshall avatar Nov 12 '21 19:11 danmarshall

This is probably semi-related - https://github.com/microsoft/SandDance/issues/392

amcdnl avatar Jan 20 '22 14:01 amcdnl