SandDance
SandDance copied to clipboard
Styling not included when spinning up example app
I tried spinning up the example in https://github.com/microsoft/SandDance/blob/master/packages/sanddance-explorer/README.md using a Create-React-App template, but all styling seems to be missing. Have missed something or is the supplied example incomplete?
I tried importing the following css import "@msrvida/sanddance-explorer/dist/css/sanddance-explorer.css"
which improved it significantly better, but still not as expected, see screenshot.
I think this still is a CSS issue. Giving the explorer component a specific height causes the sidebar to show up:
.sanddance-explorer {
height: 1000px;
}
That fixed it, thanks @Buroni! It would be great if this info could be added to the docs as it seems it is needed to get the app to render properly
Thanks @Buroni 🥇 @johanbook - we didn't make any assumptions on how consumers will size their component. We are open for pull requests, if you'd like to add this info the readme :)
@danmarshall It may be worthwhile to give .sandance-explorer
height: 100%
by default, so that it takes up the height of whatever container a user puts it in rather than collapsing to the height of the legend. This would be expected default behaviour in my opinion. I'm happy to submit a PR.
Thanks @Buroni - PRs appreciated :)