SandDance
SandDance copied to clipboard
BUG: Chart Settings -> Tools -> Show Vega spec -> Open Vega Editor does nothing in vscode
Expected:
Clicking on Open Vega Editor popup would open generated chart Vega specification in an online Vega Editor in the default browser using vscode.open
command with encoded vega spec url. See #152 for more info on the latter part.
Alternatively, you can integrate with Vega Viewer 📈 vscode extension for this part and open generated Vega specification in Vega Viewer via commands.executeCommand('vega.preview', vegaSpecUri)
duplicate of #75
it might be a duplicate, but are you going to address it & integrate it with Vega Viewer I mentioned when you resolve it? ...
besides, your #75 ticket has no description at all :)
Hi Taras, sorry about abruptly closing this 😳. I'm curious of the interaction if someone does not have the Vega-Viewer extension installed...
In that case it could just open Vega spec. json in default vscode JSON editor.
Since most Vega specs use json schema that would allow devs to review and edit that spec with IntelliSense at least.
You can check if Vega Viewer is installed and just default to: commands.executeCommand('vscode.open', vegaSpecUri)
See how I do it for Data Preview ext. in Vega Viewer to load loca data files:
https://github.com/RandomFractals/vscode-vega-viewer/issues/52
so ... long story short ... I think you have a few good options I layed out there.
Let me know if you need a hand with it :)
I would like to see us integrate this Vega cobweb for the best vscode devs & Vega viz UX eventually ...
also, @casperOne & @arvind please provide your objections to the proposed & expected behaviour in text ... & your 👎 lol! since currently SandDance just doesn't do anything for that link click in vscode :)
@domoritz what's your pref. for this fix? ...
@danmarshall any update on this? been sitting in your queue for months :)