SandDance icon indicating copy to clipboard operation
SandDance copied to clipboard

BUG: Chart Settings -> Tools -> Show Vega spec -> Open Vega Editor does nothing in vscode

Open RandomFractals opened this issue 4 years ago • 9 comments

Expected:

Clicking on Open Vega Editor popup would open generated chart Vega specification in an online Vega Editor in the default browser using vscode.open command with encoded vega spec url. See #152 for more info on the latter part.

Alternatively, you can integrate with Vega Viewer 📈 vscode extension for this part and open generated Vega specification in Vega Viewer via commands.executeCommand('vega.preview', vegaSpecUri)

RandomFractals avatar Dec 15 '19 16:12 RandomFractals

duplicate of #75

danmarshall avatar Dec 23 '19 20:12 danmarshall

it might be a duplicate, but are you going to address it & integrate it with Vega Viewer I mentioned when you resolve it? ...

RandomFractals avatar Dec 23 '19 20:12 RandomFractals

besides, your #75 ticket has no description at all :)

RandomFractals avatar Dec 23 '19 20:12 RandomFractals

Hi Taras, sorry about abruptly closing this 😳. I'm curious of the interaction if someone does not have the Vega-Viewer extension installed...

danmarshall avatar Dec 24 '19 00:12 danmarshall

In that case it could just open Vega spec. json in default vscode JSON editor.

Since most Vega specs use json schema that would allow devs to review and edit that spec with IntelliSense at least.

You can check if Vega Viewer is installed and just default to: commands.executeCommand('vscode.open', vegaSpecUri)

See how I do it for Data Preview ext. in Vega Viewer to load loca data files:

https://github.com/RandomFractals/vscode-vega-viewer/issues/52

RandomFractals avatar Dec 25 '19 13:12 RandomFractals

so ... long story short ... I think you have a few good options I layed out there.

Let me know if you need a hand with it :)

I would like to see us integrate this Vega cobweb for the best vscode devs & Vega viz UX eventually ...

RandomFractals avatar Dec 25 '19 21:12 RandomFractals

also, @casperOne & @arvind please provide your objections to the proposed & expected behaviour in text ... & your 👎 lol! since currently SandDance just doesn't do anything for that link click in vscode :)

RandomFractals avatar Dec 25 '19 21:12 RandomFractals

@domoritz what's your pref. for this fix? ...

RandomFractals avatar Dec 25 '19 22:12 RandomFractals

@danmarshall any update on this? been sitting in your queue for months :)

RandomFractals avatar Oct 15 '20 18:10 RandomFractals