<utility>: Remove self swap check from pair.

[Andor233]

Fixes #4597

[Andor233]

@microsoft-github-policy-service agree

[frederick-vs-ja]

Finally, we should add tests\GH_004597_self_swap here to ensure the MS-internal mechanisms to run this test. https://github.com/microsoft/STL/blob/8dc4faadafb52e3e0a627e046b41258032d9bc6a/tests/std/test.lst#L245-L246

[StephanTLavavej]

Thanks, this is awesome! :heart_eyes_cat: I pushed a series of fine-grained commits to follow our coding conventions in the test, but nothing serious (beyond a bug number typo).

We merge changes to the GitHub and MSVC-internal repos simultaneously in a semi-manual process. To save time, we merge PRs in batches, and your PR will be part of the next batch. I'll post comments here as I prepare this (likely later this week although possibly next week if I get busy).

[Andor233]

Thanks, this is awesome! 😻 I pushed a series of fine-grained commits to follow our coding conventions in the test, but nothing serious (beyond a bug number typo).

We merge changes to the GitHub and MSVC-internal repos simultaneously in a semi-manual process. To save time, we merge PRs in batches, and your PR will be part of the next batch. I'll post comments here as I prepare this (likely later this week although possibly next week if I get busy).

Thank you.

[StephanTLavavej]

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

[StephanTLavavej]

Thanks for fixing this bug, and congratulations on your first microsoft/STL commit! :heart_eyes_cat: :tada: :magic_wand:

This change is expected to ship in VS 2022 17.11 Preview 3.