QuantumLibraries icon indicating copy to clipboard operation
QuantumLibraries copied to clipboard

QuantumPhaseEstimation takes BigEndian argument

Open crazy4pi314 opened this issue 5 years ago • 2 comments

Describe the bug I think this is just an inconsistency, most everything uses LittleEndian and the controlRegister argument takes a BigEndian.

Expected behavior I would expect the signature for QuantumPhaseEstimation to be

    operation QuantumPhaseEstimation (
        oracle : DiscreteOracle, 
        targetState : Qubit[], 
        controlRegister : LittleEndian
    ) 
    : Unit is Adj + Ctl{
...
}

crazy4pi314 avatar Apr 29 '20 16:04 crazy4pi314

After some thought it looks like this won't be a straightforward fix so we are going to include this in https://github.com/microsoft/QuantumLibraries/issues/337, so will close this for now. Thanks @crazy4pi314 for raising this issue!

guenp avatar Nov 23 '20 18:11 guenp

Reopening this issue and assigning our new Status-ChildIssue label so we can track it as part of the #337 proposal.

guenp avatar Nov 23 '20 18:11 guenp