microsoft
Decadac fix Min/Max_values
This doesn't cover DecaDac's with a +5/-5V range (which is like the ones we have in Sydney), so this will cause issues for us?
Actually looking at #904, I initially wrote the driver with +5/-5 since those ARE the hardware limits that our DAC's use, so in fact min_val and max_val were intended to be hardware, not soft limits...
That's interesting. None of the Copenhagen decadacs have any 5 V limits. There are clearly more variations out there than we know about
Thank you @spauka ! It was really a mystery for us how the +-5V came along. What do you guys think about rewriting the driver such that it requires setting the hardware limits explicitly for it to work? Or do you @spauka know how to read out this piece of information from the device?
@Dominik-Vogel I'm not aware of a way of reading out the range unfortunately?
Actually I was unaware that it was possible for different cards within a single DAC unit to be set differently, although I was aware that there were different ranges floating around, so setting min/max_value when initializing the instrument was my solution.
Rewriting the driver to explicitly set hardware limits sounds good to me :)
@Dominik-Vogel
- [ ] Rewriting the driver to explicitly set hardware limits then we can close #904
