Qcodes icon indicating copy to clipboard operation
Qcodes copied to clipboard

Trmorgan/keyboard interrupt

Open trevormorgan opened this issue 1 year ago • 1 comments

Improved Interrupt Handling in dond Function

Description

This PR enhances the interrupt handling capabilities of the dond function in the QCoDeS dataset module. It addresses issues with the current implementation of catch_interrupts and ensures that keyboard interrupts are properly propagated and handled during measurement sweeps.

New

  • Ensured that KeyboardInterrupt is properly raised and propagated through the dond function

Testing

The updated test now correctly simulates a KeyboardInterrupt within the dond function and verifies that it's propagated as expected. This change improves our ability to test and ensure robust interrupt handling in complex measurement scenarios.

Impact

These changes improve the reliability of measurements that use the dond function, particularly in situations where users might need to interrupt long-running sweeps. It ensures that the system responds appropriately to keyboard interrupts, possible saving time due to prior option being complete abort

Additional Notes

  • This PR does not introduce any changes to the core dond function itself, only to its testing infrastructure
  • Users should not experience any changes in normal operation, but will benefit from improved interrupt handling

trevormorgan avatar Jun 21 '24 20:06 trevormorgan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.18%. Comparing base (009ec80) to head (824152d). Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6192   +/-   ##
=======================================
  Coverage   67.17%   67.18%           
=======================================
  Files         352      352           
  Lines       32132    32140    +8     
=======================================
+ Hits        21586    21594    +8     
  Misses      10546    10546           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 27 '24 17:06 codecov[bot]