Qcodes icon indicating copy to clipboard operation
Qcodes copied to clipboard

Mypy: Enable no implicit re export

Open jenshnielsen opened this issue 3 years ago • 2 comments

  • Avoid imports from pyvisa/parso that are imported from modules where they are not defined/added to __all__
  • Update internal updated to either use public api or original definition

jenshnielsen avatar Aug 24 '22 06:08 jenshnielsen

This seems to trigger a type issue with python 3.7 / old numpy versions

jenshnielsen avatar Aug 24 '22 07:08 jenshnielsen

This is waiting for us to drop 3.7 support #3889

jenshnielsen avatar Aug 24 '22 09:08 jenshnielsen

Codecov Report

Merging #4546 (6ca834f) into master (f3a432b) will decrease coverage by 0.02%. The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #4546      +/-   ##
==========================================
- Coverage   68.27%   68.25%   -0.03%     
==========================================
  Files         339      339              
  Lines       31976    31981       +5     
==========================================
- Hits        21833    21829       -4     
- Misses      10143    10152       +9     

codecov[bot] avatar Oct 04 '22 10:10 codecov[bot]