microsoft
Bump pyvisa from 1.11.3 to 1.12.0
Bumps pyvisa from 1.11.3 to 1.12.0.
Commits
- See full diff in compare view
You can trigger a rebase of this PR by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
![dependabot[bot] avatar](https://avatars.githubusercontent.com/in/29110?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Merging #4167 (2827697) into master (b91600f) will decrease coverage by
0.02%. The diff coverage isn/a.
:exclamation: Current head 2827697 differs from pull request most recent head d3a2b4e. Consider uploading reports for the commit d3a2b4e to get more accurate results
@@ Coverage Diff @@
## master #4167 +/- ##
==========================================
- Coverage 68.11% 68.09% -0.03%
==========================================
Files 299 299
Lines 31538 31535 -3
==========================================
- Hits 21483 21473 -10
- Misses 10055 10062 +7
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
2022-05-12T05:10:54.2888204Z @pytest.fixture()
2022-05-12T05:10:54.2888442Z def AMI430_3D():
2022-05-12T05:10:54.2888677Z import numpy as np
2022-05-12T05:10:54.2888881Z
2022-05-12T05:10:54.2889149Z import qcodes.instrument.sims as sims
2022-05-12T05:10:54.2889488Z from qcodes.instrument.ip_to_visa import AMI430_VISA
2022-05-12T05:10:54.2889871Z from qcodes.instrument_drivers.american_magnetics.AMI430 import AMI430_3D
2022-05-12T05:10:54.2890354Z visalib = sims.__file__.replace('__init__.py', 'AMI430.yaml@sim')
2022-05-12T05:10:54.2890906Z > mag_x = AMI430_VISA('x', address='GPIB::1::INSTR', visalib=visalib,
2022-05-12T05:10:54.2891280Z terminator='\n', port=1)
2022-05-12T05:10:54.2891437Z
2022-05-12T05:10:54.2891552Z qcodes/tests/test_logger.py:87:
2022-05-12T05:10:54.2891827Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
2022-05-12T05:10:54.2892101Z qcodes/instrument/base.py:542: in __call__
2022-05-12T05:10:54.2892382Z new_inst = super().__call__(*args, **kwargs)
2022-05-12T05:10:54.2892707Z qcodes/instrument_drivers/american_magnetics/AMI430.py:163: in __init__
2022-05-12T05:10:54.2893051Z super().__init__(name, address, port, terminator=terminator,
2022-05-12T05:10:54.2893366Z qcodes/instrument/ip_to_visa.py:71: in __init__
2022-05-12T05:10:54.2893634Z self.set_address(address)
2022-05-12T05:10:54.2893900Z qcodes/instrument/visa.py:124: in set_address
2022-05-12T05:10:54.2894203Z resource = resource_manager.open_resource(address)
2022-05-12T05:10:54.2894723Z /opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/pyvisa/highlevel.py:3284: in open_resource
2022-05-12T05:10:54.2895087Z res.open(access_mode, open_timeout)
2022-05-12T05:10:54.2895585Z /opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/pyvisa/resources/resource.py:278: in open
2022-05-12T05:10:54.2895996Z self.session, status = self._resource_manager.open_bare_resource(
2022-05-12T05:10:54.2896541Z /opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/pyvisa/highlevel.py:3209: in open_bare_resource
2022-05-12T05:10:54.2897186Z return self.visalib.open(self.session, resource_name, access_mode, open_timeout)
2022-05-12T05:10:54.2899865Z /opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/pyvisa_sim/highlevel.py:121: in open
2022-05-12T05:10:54.2900227Z sess = cls(session, resource_name, parsed)
2022-05-12T05:10:54.2900725Z /opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/pyvisa_sim/sessions.py:79: in __init__
2022-05-12T05:10:54.2901070Z self.after_parsing()
2022-05-12T05:10:54.2901327Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Looks like there now is a problem with gpib instruments without a secondary address. This used to normally default to 0/1 (whatever the default is) Its unclear if this is
- Intentional breaking change
- a bug in pyvisa
- a bug in pyvisa-sim
Need to investigate
Probably fixed by https://github.com/pyvisa/pyvisa-sim/pull/59 which is not yet in a release of pyvisa-sim
@astafan8 I can see 3 options to support pyvisa 1.12
- Wait for a release of pyvisa-sim with the fix
- Install pyvisa-sim from the master branch
- Workaround the issue by adding secondary adresses to all gpib test instruments
What do you think?
i'd vote for "Workaround the issue by adding secondary adresses to all gpib test instruments". and once "Wait for a release of pyvisa-sim with the fix" happens for real, next pyvisa sims won't have to use the secondary addresses as they didn't have to in pyvisa 1.11.3 :)
@astafan8 tried upgrading the gpib adresses. There are a lot of then :(
For this to work we whould also need to update the device mappings in the yaml files
Update Pyvisa-sim is now out with a fix so no need for this