Qcodes icon indicating copy to clipboard operation
Qcodes copied to clipboard

Unique name for instrument logger

Open jenshnielsen opened this issue 5 years ago • 2 comments

This ensures that each instrument will have it's own logger so that messages can easily be filtered by instrument instance

An instrument will have a logger with a name of the form module.path.to.instrument.classname-instancename and in the same way a channel will have a logger with a name of the form module.path.to.instrument.classname-instancename.channelclassname-channelinstancename

@Dominik-Vogel

jenshnielsen avatar Feb 03 '20 14:02 jenshnielsen

If we go that way there should be some tests added

jenshnielsen avatar Feb 03 '20 14:02 jenshnielsen

Codecov Report

Merging #1914 into master will decrease coverage by 0.77%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1914      +/-   ##
==========================================
- Coverage   68.92%   68.14%   -0.78%     
==========================================
  Files         156      156              
  Lines       19924    19929       +5     
==========================================
- Hits        13732    13581     -151     
- Misses       6192     6348     +156     

codecov[bot] avatar Feb 03 '20 14:02 codecov[bot]

This is now replaced by https://github.com/QCoDeS/Qcodes/pull/5297 which will ensure that the instrument_name is an extra attribute on the logrecord from the instrument LoggerAdapter

jenshnielsen avatar Aug 01 '23 13:08 jenshnielsen