Qcodes icon indicating copy to clipboard operation
Qcodes copied to clipboard

Unify default values of arguments for all snapshot_base and snapshot methods in qcodes repo

Open astafan8 opened this issue 6 years ago • 3 comments

Description

To promote "the same" behavior unless needed explicitly. (i think that it's good, but if there are use cases against that i'm happy to hear about those here)

Note that right before merging the commits in this PR will be rebased on the lastest master for a cleaner history :)

Places in question:

  • [ ] https://github.com/QCoDeS/Qcodes/blob/295ad9043ba52d61432b4e73ab1a39714572bb0c/qcodes/instrument_drivers/ZI/ZIHDAWG8.py#L79-L81 the ZIHDAWG8 driver - does anyone remember why is this override needed? how is this instrument special to all the other instruments?

astafan8 avatar Nov 20 '19 12:11 astafan8

Codecov Report

Merging #1830 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1830   +/-   ##
=======================================
  Coverage   70.37%   70.37%           
=======================================
  Files         152      152           
  Lines       18859    18859           
=======================================
  Hits        13272    13272           
  Misses       5587     5587

codecov[bot] avatar Nov 20 '19 13:11 codecov[bot]

@jenshnielsen @Dominik-Vogel what do you think about this PR? also about the question in the description?

astafan8 avatar Nov 29 '19 15:11 astafan8

I need a bit of time to reevaluate the chaining before I can make my mind of if this

jenshnielsen avatar Dec 05 '19 10:12 jenshnielsen

closing in favor of #4808

astafan8 avatar Nov 16 '22 10:11 astafan8