Unify default values of arguments for all snapshot_base and snapshot methods in qcodes repo
Description
To promote "the same" behavior unless needed explicitly. (i think that it's good, but if there are use cases against that i'm happy to hear about those here)
Note that right before merging the commits in this PR will be rebased on the lastest master for a cleaner history :)
Places in question:
- [ ] https://github.com/QCoDeS/Qcodes/blob/295ad9043ba52d61432b4e73ab1a39714572bb0c/qcodes/instrument_drivers/ZI/ZIHDAWG8.py#L79-L81
the
ZIHDAWG8driver - does anyone remember why is this override needed? how is this instrument special to all the other instruments?
Codecov Report
Merging #1830 into master will not change coverage. The diff coverage is
100%.
@@ Coverage Diff @@
## master #1830 +/- ##
=======================================
Coverage 70.37% 70.37%
=======================================
Files 152 152
Lines 18859 18859
=======================================
Hits 13272 13272
Misses 5587 5587
@jenshnielsen @Dominik-Vogel what do you think about this PR? also about the question in the description?
I need a bit of time to reevaluate the chaining before I can make my mind of if this
closing in favor of #4808