5014c warning
Fixes #1231
@jenshnielsen
Codecov Report
Merging #1254 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #1254 +/- ##
=======================================
Coverage 70.52% 70.52%
=======================================
Files 103 103
Lines 11608 11608
=======================================
Hits 8186 8186
Misses 3422 3422
I think it would be good have a slightly more "luxurious" version of this check. I'm imagining something like having a function that can determine whether a given sequence is playable using a software sequencer (does it have illegal trigger waits, etc.) and another one that checks if a given sequence will trigger using the software sequencer. By implementing that, we will also be able to give very helpful warnings and error messages, along the lines of Error: trigger wait on element 3 is incompatible with software sequencer, but length (120 points < 250 points) of element 5 forces instrument to use software sequencer. Cannot proceed. Ultimately, we want to protect users and ourselves from ever having to figure out this stuff manually again.