PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

Updates to WinGet publish script

Open mdanish-kh opened this issue 6 months ago • 4 comments

Summary of the Pull Request

Few updates to the WinGet publish workflow action

  • Use GitHub release event instead of manually making an API call to GitHub API and then fetching the target release. The target release is directly accessible via the event. The refactor is similar to the GitHub action of microsoft/edit repo's workflow
  • With the latest winget-create release, the preferred method for providing the GitHub token in CI/CD environment is via the environment variable WINGET_CREATE_GITHUB_TOKEN. Removed use of --token and switched to environment variable. See https://aka.ms/winget-create-token for details.

mdanish-kh avatar Jun 11 '25 21:06 mdanish-kh

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

JLO

These words are not needed and should be removed iwr

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:mdanish-kh/PowerToys.git repository on the winget-create-env branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/15595827902/attempts/1' &&
git commit -m 'Update check-spelling metadata'
Pattern suggestions :scissors: (1)

You could add these patterns to .github/actions/spell-check/patterns.txt:

# Automatically suggested patterns

# hit-count: 1 file-count: 1
# curl arguments
\b(?:\\n|)curl(?:\.exe|)(?:\s+-[a-zA-Z]{1,2}\b)*(?:\s+-[a-zA-Z]{3,})(?:\s+-[a-zA-Z]+)*

Alternatively, if a pattern suggestion doesn't make sense for this project, add a # to the beginning of the line in the candidates file with the pattern to stop suggesting it.

Notices :information_source: (1)

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:information_source: Notices Count
:information_source: candidate-pattern 1

See :information_source: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Jun 11 '25 21:06 github-actions[bot]

/azp run

yeelam-gordon avatar Jun 12 '25 01:06 yeelam-gordon

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 12 '25 01:06 azure-pipelines[bot]

I assume we can only try it for the next time for official release?

yeelam-gordon avatar Jun 12 '25 01:06 yeelam-gordon

I assume we can only try it for the next time for official release?

One can test the workflow in their fork by making a dummy release with dummy installers (with the same file name conventions, and by removing --submit so that it doesn't actually submit a PR), or you can take a look at the microsoft/edit's workflow which is pretty similar and it had a release run recently

mdanish-kh avatar Jun 12 '25 18:06 mdanish-kh