PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

workspaces: shell:appsfolder launch does not support the command line

Open vanzue opened this issue 7 months ago • 4 comments

Fix #39427

Summary of the Pull Request

Fix a regression when supporting steam games launch in workspaces by this PR #38380 Try to launch steam game with shell:\appsfolder/appusermodelid image

  • When an app has appusermodelid, it will fall to shell:appsfolder + \appusermodelid, while this launch does not support command line. So command line is broken

When doing release check, use terminal as the "command line testing app", that works fine, so missed this one.

This pr restrict the scope of specific launch case for steam games

PR Checklist

  • [ ] Closes: #xxx
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Locally verified for edge and visual studio, and make sure steam games still work https://github.com/microsoft/PowerToys/issues/39427

vanzue avatar May 15 '25 02:05 vanzue

/azp run

vanzue avatar May 16 '25 08:05 vanzue

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 16 '25 08:05 azure-pipelines[bot]

/azp run

vanzue avatar May 17 '25 00:05 vanzue

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 17 '25 00:05 azure-pipelines[bot]