PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

PowerToys.MonacoPreviewHandler crashes when rendering UTF-8 BOM

Open crutkas opened this issue 7 months ago • 3 comments

Summary of the Pull Request

PR Checklist

  • [ ] Closes: https://github.com/microsoft/PowerToys/issues/35258
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

crutkas avatar May 12 '25 16:05 crutkas

this should test but for some reason, i can't get monaco to work on this computer currently even on .90.1, quickly whipped up a bom file in theory to test creating a file with utf-8 BOM.txt

crutkas avatar May 12 '25 16:05 crutkas

/azp run

crutkas avatar May 14 '25 19:05 crutkas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 14 '25 19:05 azure-pipelines[bot]

Tested and LGTM

lei9444 avatar Jun 10 '25 14:06 lei9444