PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

Fix fancyzone editor dpi awareness

Open HO-COOH opened this issue 7 months ago • 9 comments

Summary of the Pull Request

Enable dpi aware of FancyZone Editor.

Context: I happened to drag the editor window to my other monitor that has a different dpi, and the text are blurry.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Manual.

HO-COOH avatar May 11 '25 16:05 HO-COOH

@yeelam-gordon should this be in a prop file so all wpf projects are per monitor?

crutkas avatar May 12 '25 17:05 crutkas

@yeelam-gordon should this be in a prop file so all wpf projects are per monitor?

Is not per csproj props/targets, but it is per manifest file, and we cannot share the manifest settings. If we need to do, we need to use like powershell to override.

yeelam-gordon avatar Jun 10 '25 05:06 yeelam-gordon

Could you also apply this change to workspacesEditor?

https://github.com/microsoft/PowerToys/blob/0d29f6aca685d6ed8733a6d4ea045883bb66964c/src/modules/Workspaces/WorkspacesEditor/app.manifest#L54

Done

HO-COOH avatar Jun 10 '25 17:06 HO-COOH

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

GC'd

These words are not needed and should be removed DEFT iextn localappdata msvsmon OTHERUNZOOM OTHERZOOM PARENTCLOSING PARENTOPENING pswd SCROLLCHILDREN SHELLEXTENSION SHELLNEWVALUE SHGFIICON SHGFILARGEICON TGM VARENUM

Some files were automatically ignored :see_no_evil:

These sample patterns would exclude them:

^\Q.pipelines/272MSSharedLibSN2048.snk\E$
^src/modules/ZoomIt/ZoomIt/ZoomIt\.idc$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct, update file exclusions, and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:HO-COOH/PowerToys.git repository on the fix/fz_dpiaware branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/15566502919/attempts/1' &&
git commit -m 'Update check-spelling metadata'
Warnings :warning: (4)

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

:warning: Warnings Count
:warning: binary-file 1
:warning: ignored-expect-variant 2
:warning: no-newline-at-eof 2
:warning: single-line-file 1

See :warning: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Jun 10 '25 17:06 github-actions[bot]

/azp run

shuaiyuanxx avatar Jun 11 '25 05:06 shuaiyuanxx

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 11 '25 05:06 azure-pipelines[bot]

/azp run

crutkas avatar Jun 11 '25 16:06 crutkas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 11 '25 16:06 azure-pipelines[bot]

@shuaiyuanxx this is something we have to merge in as a community member can't.

crutkas avatar Jun 12 '25 06:06 crutkas