PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

Add shproj and projitems extensions to monaco_languages.json

Open rezanid opened this issue 11 months ago • 2 comments

Both ".shproj" and ".projitems" are extensions using by Microsoft Visual Studio for Shared Projects. The files are standard XML.

Summary of the Pull Request

PR Checklist

  • [X] Closes: #39247
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

This PR simply adds two new extensions to XML for Monaco preview. Both extensions are known by Visual Studio.

Validation Steps Performed

No automated test. Monaco has a configuration file that works like a dictionary to define supported languages and their extensions. I added the two extensions to this file for XML language.

rezanid avatar May 05 '25 08:05 rezanid

Hi @rezanid, monaco_languages.json is a generated file. Your contribution would get overwritten the next time someone regenerates it. In order to properly add support for the new extensions you need to add them in monacoSpecialLanguages.js (see the docs).

PesBandi avatar May 05 '25 16:05 PesBandi

Hi @PesBandi, thanks for your quick feedback. Good piece of info! I will correct it.

rezanid avatar May 05 '25 18:05 rezanid

Sorry for letting this sit - there were some changes to our CI recently, and you'll need to re-merge the latest main into this PR to get the CI happy. Sorry about that!

(also, this needs to be fixed anyways)

zadjii-msft avatar Jul 09 '25 18:07 zadjii-msft

Looks like this file should be modifed: https://github.com/microsoft/PowerToys/blob/main/src/Monaco/monacoSpecialLanguages.js

Updated in next commit

yeelam-gordon avatar Aug 22 '25 01:08 yeelam-gordon

/azp run

yeelam-gordon avatar Aug 22 '25 03:08 yeelam-gordon

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 22 '25 03:08 azure-pipelines[bot]