microsoft
Fix the problem which Powertoys Run shows duplicated applications.
Summary of the Pull Request
- In the previous PR, we check in a fix to make shelllink helper open .ink file non-exclusively. It would always throw exception. So, in that time this fix is work.
- We will load all application on the start and filter the duplicated one by "FullPath", which will be retrieved from the shellLink helper. But it failed, so we can not set the correct value.
PR Checklist
- [ ] Closes: #xxx
- [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
- [ ] Tests: Added/updated and all pass
- [ ] Localization: All end user facing strings can be localized
- [ ] Dev docs: Added/updated
- [ ] New binaries: Added on the required places
- [ ] JSON for signing for new binaries
- [ ] WXS for installer for new binaries and localization folder
- [ ] YML for CI pipeline for new test projects
- [ ] YML for signed pipeline
- [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
But isn't this bringing the other issue back?
@htcfreek Which one? if you mean the MSI installer issue, no.
MSI installer will trigger the OnRename event (Actually I don't know why), and we added one second sleep for this event. It could significantly reduce the conflict probabilities.
Wow. This will slow down plugin or at least plugin init.
I guess not. I remembered this OnRename event only triggered in plugin running.
The initially results are collected by the GetAll (or All?) method.
I guess the only impact is, the result update will delay one second...
I'm not sure, if anyone have some context on this plugin, please add comments here.