Color picker wpf

[mantaionut]

Summary of the Pull Request

Use .net WPF instead of WPFUI.

PR Checklist

• [ ] Closes: #xxx
• [x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• [ ] Tests: Added/updated and all pass
• [ ] Localization: All end user facing strings can be localized
• [ ] Dev docs: Added/updated
• [ ] New binaries: Added on the required places
  • [ ] JSON for signing for new binaries
  • [ ] WXS for installer for new binaries and localization folder
  • [ ] YML for CI pipeline for new test projects
  • [ ] YML for signed pipeline
• [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Comparison Windows 11. Left side new one, right side old one. Light

Dark

Aquatic

Desert

Dusk

Night Sky

Validation Steps Performed

Test on W11 and W10, dark and light and all HC themes.

[Jay-o-Way]

First image on the left shows a button with black text on a green background. This is not good accessibility. Let's see how to fix that. (my general advice: stick with the basics)

[shuaiyuanxx]

The code looks good, but I do have one small concern: the original UI didn’t seem to have any problems, so why switch to .NET WPF?

[mantaionut]

I've updated the select button to use the accent style. Below are the screenshots for W11. Dark Light Aquatic Desert Dusk Night Sky

[jaimecbernardo]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[crutkas]

On Windows 10, the title bar doesn't look good. It doesn't seem to follow the Fluent Style like in 0.88. This is how Dark mode is looking to me on W10:

wondering if this is a wpf issue or an 'us' issue

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (4)

GWLSTYLE TPMLEFTALIGN TPMRETURNCMD WMSYSCOMMAND

These words are not needed and should be removed

ahk AMPROPERTY AMPROPSETID Breadcrumb CDEF comdef ddf devenum DEVMON DEVSOURCE DGR DIIRFLAG dshow DVH DVHD DVSD DVSL EData ERole fdw FILEINFOSIG Filtergraph Filterx HCERTSTORE IKs iljxck IYUV KSPROPERTY lcb ldx lld LONGLONG LTRB majortype makecab MEDIASUBTYPE mediatype mfplat mic mjpg Msimg msiquery ORAW outpin overlaywindow PAUDIO PINDIR Pnp ppmt previouscamera PROPBAG propvarutil reencoded REFGUID REGFILTER REGFILTERPINS REGPINTYPES regsvr shmem sizeread stl strsafe strutil subquery SYNCMFT TMPVAR vcdl vdi vid VIDCAP VIDEOINFOHEADER vih webcam wistd WVC

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:mantaionut/PowerToys.git repository on the color_picker_wpf branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/13633637172/attempts/1'

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[crutkas]

Does this happen in the updated UX? https://github.com/microsoft/PowerToys/issues/37801 I can repro this in the current .89 build.

[crutkas]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[mantaionut]

@crutkas #37801 still happens in this PR.

[jaimecbernardo]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[jaimecbernardo]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).