PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

Enable MTP

Open Youssef1313 opened this issue 11 months ago • 36 comments

Summary of the Pull Request

Update MSTest to latest and switch to Microsoft.Testing.Platform instead of VSTest.

PR Checklist

  • [ ] Closes: #xxx
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Youssef1313 avatar Jan 22 '25 05:01 Youssef1313

I'm not seeing a build triggered on this PR. Is CI for this repo manually triggered?

Youssef1313 avatar Jan 22 '25 05:01 Youssef1313

/azp run

crutkas avatar Jan 22 '25 09:01 crutkas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 22 '25 09:01 azure-pipelines[bot]

@Youssef1313 can you ping me internally? I would love to ask a few questions on this.

@DHowett as FYI

crutkas avatar Jan 22 '25 09:01 crutkas

Thanks for opening this PR. CI is failing because of some XAML style errors that got into main. Please merge latest main in to fix that. Thank you

jaimecbernardo avatar Jan 22 '25 12:01 jaimecbernardo

/azp run

Youssef1313 avatar Jan 22 '25 13:01 Youssef1313

Commenter does not have sufficient privileges for PR 37001 in repo microsoft/PowerToys

azure-pipelines[bot] avatar Jan 22 '25 13:01 azure-pipelines[bot]

/azp run

crutkas avatar Jan 22 '25 17:01 crutkas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 22 '25 17:01 azure-pipelines[bot]

@crutkas Could you run the pipeline please? Thanks!

Youssef1313 avatar Jan 27 '25 16:01 Youssef1313

/azp run

crutkas avatar Jan 27 '25 17:01 crutkas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 27 '25 17:01 azure-pipelines[bot]

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(473,5): error MSB8070: Cannot find MSVC toolset version '14.42.34436': the folder 'C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.42.34436\' does not exist. Please make sure MSVC toolset version '14.42.34436' is  installed or choose another toolset version. [D:\a\_work\1\s\src\common\Telemetry\EtwTrace\EtwTrace.vcxproj]

@crutkas @jaimecbernardo Is this related to https://github.com/microsoft/PowerToys/pull/37098?

Youssef1313 avatar Jan 27 '25 19:01 Youssef1313

Yes @Youssef1313 , please merge latest main to fix :)

jaimecbernardo avatar Jan 27 '25 19:01 jaimecbernardo

Thank you. Could you please run the pipeline again?

Youssef1313 avatar Jan 28 '25 04:01 Youssef1313

/azp run

crutkas avatar Jan 29 '25 05:01 crutkas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 29 '25 05:01 azure-pipelines[bot]

@crutkas I pushed some more changes

Youssef1313 avatar Jan 29 '25 12:01 Youssef1313

/azp run

crutkas avatar Jan 29 '25 14:01 crutkas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 29 '25 14:01 azure-pipelines[bot]

/azp run

crutkas avatar Jan 30 '25 05:01 crutkas

Azure Pipelines failed to run 1 pipeline(s).

azure-pipelines[bot] avatar Jan 30 '25 05:01 azure-pipelines[bot]

@crutkas I did more changes if you can re-run the pipeline again please

Youssef1313 avatar Jan 30 '25 10:01 Youssef1313

/azp run

DHowett avatar Jan 30 '25 16:01 DHowett

Azure Pipelines failed to run 1 pipeline(s).

azure-pipelines[bot] avatar Jan 30 '25 16:01 azure-pipelines[bot]

@DHowett @crutkas Could you please run the pipeline here? Thanks!

Youssef1313 avatar Feb 18 '25 19:02 Youssef1313

/azp run

crutkas avatar Feb 18 '25 20:02 crutkas

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 18 '25 20:02 azure-pipelines[bot]

/azp run

Youssef1313 avatar Feb 19 '25 15:02 Youssef1313

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Feb 19 '25 15:02 azure-pipelines[bot]