PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[runner]Fix triggering non-set hotkeys

Open stefansjfw opened this issue 1 year ago • 6 comments

Summary of the Pull Request

Apparently, left-clicking Slack systray icon sends None (vkCode = 0) keyboard input. As all of the modifier keys are false (if not pressed) this is the same as key combination as default non-set Hotkey{}. therefore, whatever non-set hotkey was not set - was triggered.

PR Checklist

  • [x] Closes: #32971
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Without this fix:

  • Copy some text
  • Left click slack systray icon and observe that text is pasted into slack input text box

With the fix:

  • Follow the same steps and observe that nothing is pasted into slack

stefansjfw avatar May 22 '24 12:05 stefansjfw

/azp run

stefansjfw avatar May 22 '24 13:05 stefansjfw

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 22 '24 13:05 azure-pipelines[bot]

/azp run

stefansjfw avatar May 22 '24 18:05 stefansjfw

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 22 '24 18:05 azure-pipelines[bot]

/azp run

stefansjfw avatar May 23 '24 08:05 stefansjfw

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 23 '24 08:05 azure-pipelines[bot]

/azp run

jaimecbernardo avatar May 23 '24 17:05 jaimecbernardo

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 23 '24 17:05 azure-pipelines[bot]

/azp run

stefansjfw avatar May 23 '24 17:05 stefansjfw

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 23 '24 17:05 azure-pipelines[bot]

/azp run

stefansjfw avatar May 23 '24 19:05 stefansjfw

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 23 '24 19:05 azure-pipelines[bot]

/azp run

stefansjfw avatar May 23 '24 20:05 stefansjfw

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 23 '24 20:05 azure-pipelines[bot]

/azp run

ghost avatar Jul 13 '24 11:07 ghost