Full fix for installation issue when My Documents on network drive

[drawbyperpetual]

Summary of the Pull Request

Full fix for https://github.com/microsoft/PowerToys/issues/32341 that works for both per-user and per-machine installs.

PR Checklist

PR Checklist

• [X ] Closes: #32341
• [X ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• [ ] Tests: Added/updated and all pass
• [ ] Localization: All end user facing strings can be localized
• [ ] Dev docs: Added/updated
• [ ] New binaries: Added on the required places
  • [ ] JSON for signing for new binaries
  • [ ] WXS for installer for new binaries and localization folder
  • [ ] YML for CI pipeline for new test projects
  • [ ] YML for signed pipeline
• [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

• A new custom action unconditionally writes DSC assets onto [INSTALL FOLDER]\DSCModules.
• A new custom action is used to install DSC assets to the correct location in the case of a per-user install. These are copied from the [INSTALL FOLDER]\DSCModules location.
• A WiX-based install is performed (as before) in case of a per-machine install.

Validation Steps Performed

When My Documents is on a network drive (and also when this is not the case),

• Checked DSC assets correctly installed when installing PerUser / PerMachine.
• Checked DSC assets correctly installed when upgrading PerUser.
• Checked DSC assets correctly deleted when uninstalling PerUser / PerMachine. Note that occasionally, the containing folder (e.g. Microsoft.PowerToys.Configure\v0.0.1) is not correctly deleted when My Documents is on a network drive. I think this is because there is a latency-related issue with detecting that the folder is empty on the network drive shortly after having deleted files on it. Note that this issue never seems to occur when My Documents is on a regular drive; the containing folder always correctly gets deleted.

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (2)

EConfigure EPower

Previously acknowledged words that are now absent

COMMANDTITLE FILELOCKSMITHLIB gdnbaselines interactable JArray ksh localport OOBEPT Pathto qwertyuiopasdfghjklzxcvbnm qwrtyuiopsghjklzxvnm redirectedfrom runsettings testhost toggleswitch 🫥

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:drawbyperpetual/PowerToys.git repository on the dev/ani/better-fix-for-my-docs-on-network-drive branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/9025866445/attempts/1'

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary

This includes both expected items (1876) from .github/actions/spell-check/expect.txt and unrecognized words (2)

Dictionary	Entries	Covers	Uniquely
cspell:r/src/r.txt	543	1	1
cspell:cpp/src/people.txt	23	1
cspell:cpp/src/ecosystem.txt	51	1

Consider adding them (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

      with:
        extra_dictionaries:
          cspell:r/src/r.txt
          cspell:cpp/src/people.txt
          cspell:cpp/src/ecosystem.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling2.yml) for uses: check-spelling/[email protected] in its with:

check_extra_dictionaries: ''

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[drawbyperpetual]

@microsoft-github-policy-service agree company="Microsoft"