PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[Monaco] CSP has no extension associated with it in `monaco_languages.json`.

Open PesBandi opened this issue 9 months ago • 6 comments

Microsoft PowerToys version

0.80.1

Installation method

GitHub

Running as admin

None

Area(s) with issue?

File Explorer: Preview Pane, Peek

Steps to reproduce

This piece of code in monaco_languages.json.

{
    "id": "csp",
    "extensions": [],
    "aliases": [
        "CSP",
        "csp"
    ]
}

It seems that .csp files were intended to be previewable. However since extensions is empty, they aren't.

✔️ Expected Behavior

No response

❌ Actual Behavior

No response

Other Software

No response

PesBandi avatar May 08 '24 09:05 PesBandi

cc: @Aaron-Junker

htcfreek avatar May 10 '24 22:05 htcfreek

This would have to be fixed in the monaco source code: https://github.com/microsoft/monaco-editor/blob/main/src%2Fbasic-languages%2Fcsp%2Fcsp.contribution.ts#L13

Aaron-Junker avatar May 11 '24 05:05 Aaron-Junker

@Aaron-Junker Is there in issue in Monaco's repository or do you plan to open a fix PR?

htcfreek avatar May 11 '24 05:05 htcfreek

@Aaron-Junker PR in monaco repo is merged and marked for the May release. Can you please update monaco after the release?

htcfreek avatar May 30 '24 16:05 htcfreek

fyi: Thanks all for flagging

crutkas avatar May 31 '24 18:05 crutkas

@crutkas , @Aaron-Junker The monaco version including the fix was released 8 days ago. We can update our dependency.

htcfreek avatar Jun 28 '24 15:06 htcfreek