PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[QuickAccent] Adding Enable/Disable Hotkey

Open Mahfoudh94 opened this issue 1 year ago • 16 comments

Summary of the Pull Request

it adds the ability to enable/disable QuickAccent using a global hotkey without the need to enter the settings every time you don't need this utility (the clip is blocky because of the recorder + conversion to GIF) quickaccent

PR Checklist

  • [x] Closes: #22205
  • [x] Communication: I've discussed this with core contributors already. (I got this task assigned to me)
  • [ ] Tests: Added/updated and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places (None were added)
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Mahfoudh94 avatar Feb 14 '24 00:02 Mahfoudh94

@microsoft-github-policy-service agree


Mahfoudh94 avatar Feb 14 '24 00:02 Mahfoudh94

Help is welcome as I have a problem formatting src\settings-ui\Settings.UI\SettingsXAML\Views\PowerAccentPage.xaml

Mahfoudh94 avatar Feb 14 '24 00:02 Mahfoudh94

Was it intentional to upgrade winrt? It causes a huge number of file changes. Ref #31396

Jay-o-Way avatar Feb 14 '24 20:02 Jay-o-Way

Was it intentional to upgrade winrt?

No, it wasn't, as of one time trying to get into the repositories management system, I pulled again from the main branch which was at the time updated with that winrt thing. As such I reverted the changes at the end, if you know how to remove them entirely from the fork, I'd be thankful for you to tell me how.

Mahfoudh94 avatar Feb 14 '24 21:02 Mahfoudh94

Okay. The merge includes changes from the main branch.

Jay-o-Way avatar Feb 14 '24 23:02 Jay-o-Way

It shouldn't have been implemented in my commit, however it got included as a merge, therefor I removed it

Mahfoudh94 avatar Feb 15 '24 09:02 Mahfoudh94

If it were me, I think I would create a new, fresh branch. Then maybe cherry-pick the correct commits(s) to the new one. Or, sometimes when I think a branch/pr is getting too messy, I just start over. @crutkas your tip?

Jay-o-Way avatar Feb 15 '24 10:02 Jay-o-Way

Yeah, this is weird. Why is there a revert? Can you please update your branch to only have the commits that include your changes?

jaimecbernardo avatar Feb 15 '24 16:02 jaimecbernardo

Thanks for opening this PR, by the way.

jaimecbernardo avatar Feb 15 '24 16:02 jaimecbernardo

I would create a new, fresh branch. Then maybe cherry-pick the correct commits(s)

So here comes the cherry-pick handy..., okay I'll give it a try, thanks

Thanks for opening this PR

Don't mention it, it is thanks to you two for being here helping me

as for why the revert, when the new code where implemented from the pull, it raises problems from "Audit deps.json files for all applications" step, you can check it on azure pipelines

Mahfoudh94 avatar Feb 15 '24 16:02 Mahfoudh94

Actually, that "Audit deps.json files for all applications" step was caused by the Visual Studio 17.9 update in the CI. A fix has been done in main already, so I've merged main in, which should fix that.

jaimecbernardo avatar Feb 15 '24 16:02 jaimecbernardo

understood, now I should go and cherry-pick only those code changes I've done, then what? open a new pull request or is there a way to update this PR and take it from another branch? EDIT: I think the last question was a dumb question on my end, like I forgot I was a developer 😅

Mahfoudh94 avatar Feb 15 '24 16:02 Mahfoudh94

There it is, cleaned and cherry-picked. Hoping it all goes well.

Mahfoudh94 avatar Feb 15 '24 22:02 Mahfoudh94

@jaimecbernardo, still waiting for your approval, and it happens there is a merge conflict because I added to the strings Resources.resw

Mahfoudh94 avatar Feb 16 '24 17:02 Mahfoudh94