[QuickAccent] Adding Enable/Disable Hotkey
Summary of the Pull Request
it adds the ability to enable/disable QuickAccent using a global hotkey without the need to enter the settings every time you don't need this utility (the clip is blocky because of the recorder + conversion to GIF)
PR Checklist
- [x] Closes: #22205
- [x] Communication: I've discussed this with core contributors already. (I got this task assigned to me)
- [ ] Tests: Added/updated and all pass
- [ ] Localization: All end user facing strings can be localized
- [ ] Dev docs: Added/updated
- [ ] New binaries: Added on the required places (None were added)
- [ ] JSON for signing for new binaries
- [ ] WXS for installer for new binaries and localization folder
- [ ] YML for CI pipeline for new test projects
- [ ] YML for signed pipeline
- [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
@microsoft-github-policy-service agree
Help is welcome as I have a problem formatting src\settings-ui\Settings.UI\SettingsXAML\Views\PowerAccentPage.xaml
Was it intentional to upgrade winrt? It causes a huge number of file changes. Ref #31396
Was it intentional to upgrade winrt?
No, it wasn't, as of one time trying to get into the repositories management system, I pulled again from the main branch which was at the time updated with that winrt thing. As such I reverted the changes at the end, if you know how to remove them entirely from the fork, I'd be thankful for you to tell me how.
Okay. The merge includes changes from the main branch.
It shouldn't have been implemented in my commit, however it got included as a merge, therefor I removed it
If it were me, I think I would create a new, fresh branch. Then maybe cherry-pick the correct commits(s) to the new one. Or, sometimes when I think a branch/pr is getting too messy, I just start over. @crutkas your tip?
Yeah, this is weird. Why is there a revert? Can you please update your branch to only have the commits that include your changes?
Thanks for opening this PR, by the way.
I would create a new, fresh branch. Then maybe cherry-pick the correct commits(s)
So here comes the cherry-pick handy..., okay I'll give it a try, thanks
Thanks for opening this PR
Don't mention it, it is thanks to you two for being here helping me
as for why the revert, when the new code where implemented from the pull, it raises problems from "Audit deps.json files for all applications" step, you can check it on azure pipelines
Actually, that "Audit deps.json files for all applications" step was caused by the Visual Studio 17.9 update in the CI. A fix has been done in main already, so I've merged main in, which should fix that.
understood, now I should go and cherry-pick only those code changes I've done, then what? open a new pull request or is there a way to update this PR and take it from another branch? EDIT: I think the last question was a dumb question on my end, like I forgot I was a developer 😅
There it is, cleaned and cherry-picked. Hoping it all goes well.
@jaimecbernardo, still waiting for your approval, and it happens there is a merge conflict because I added to the strings Resources.resw