PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

Image resizer: UI tweaks

Open Jay-o-Way opened this issue 1 year ago • 1 comments

Summary of the Pull Request

  • Placed text in a TextBlock inside the CheckBoxes, to apply TextWrapping
    • had to remove the _underscores, because they would be printed otherwise
  • tweaked a few sizes with a few pixels

PR Checklist

  • [ ] Closes: none
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [x] Localization: All end user facing strings can be localized
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

[!NOTE] I wanted to start fixing #29098, but when debugging, the (minimum) Height of the window is always too large to test. Even when ResizeMode="CanResize". How do I solve this?

Validation Steps Performed

Before image After image

Jay-o-Way avatar Jan 18 '24 18:01 Jay-o-Way

@niels9001 If you know why the window has a minimum size - and how to override it to double check the behavior - that would be nice. Otherwise, this is a rather small pr.

Jay-o-Way avatar Jan 23 '24 12:01 Jay-o-Way

@niels9001 If you know why the window has a minimum size - and how to override it to double check the behavior - that would be nice. Otherwise, this is a rather small pr.

Does setting MinWidth to 0 work? Might be that WPF has an internal MinWidth on windows, not sure though.

niels9001 avatar Jan 23 '24 12:01 niels9001

Hi @Jay-o-Way , have you tried using AccessText instead of TextBlock? Thinking you can keep accelerator key that way with _.

jaimecbernardo avatar Jan 25 '24 16:01 jaimecbernardo

Regarding the accelerator keys, why are we changing them vs the ones that were there before?

Oh indeed, 'cause I removed them (because I started with a TextBlock) and then added them manually later (the letters made sense to me). Can revert to the previous letters, if you want?

Jay-o-Way avatar Feb 06 '24 12:02 Jay-o-Way

Regarding the accelerator keys, why are we changing them vs the ones that were there before?

Oh indeed, 'cause I removed them (because I started with a TextBlock) and then added them manually later (the letters made sense to me). Can revert to the previous letters, if you want?

Please do, let's try to keep behavior as before 😄

jaimecbernardo avatar Feb 06 '24 15:02 jaimecbernardo

Okay. I have a lot of problems with this branch on my computer. Thinking of doing a new branch.

Jay-o-Way avatar Feb 06 '24 16:02 Jay-o-Way

Okay. I have a lot of problems with this branch on my computer. Thinking of doing a new branch.

Maybe remove the entire PowerToys folder and do a fresh clone?

niels9001 avatar Feb 06 '24 17:02 niels9001