PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[Peek] WindowActivationState checks are added for focus and close aft…

Open gokcekantarci opened this issue 2 years ago • 6 comments

…er losing focus.

Summary of the Pull Request

PR Checklist

  • [ ] Closes: #26366
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

gokcekantarci avatar May 26 '23 13:05 gokcekantarci

Do we having a tracking issue for this

crutkas avatar May 26 '23 13:05 crutkas

Do we having a tracking issue for this

A new issue opened and added to PR.

gokcekantarci avatar May 26 '23 15:05 gokcekantarci

I'll be adding a Setting for enabling/disabling this behavior.

jaimecbernardo avatar May 26 '23 15:05 jaimecbernardo

Also need to check if this doesn't break https://github.com/microsoft/PowerToys/pull/26349

jaimecbernardo avatar May 26 '23 15:05 jaimecbernardo

I'll be adding a Setting for enabling/disabling this behavior.

I am also in favor of adding a Setting light dismiss. It can be very frustrating especially since it is not a window's normal behavior.

SamChaps avatar May 26 '23 17:05 SamChaps

I've added a setting for this, off by default: image

Also added a Service to the Peek.UI to get the settings, now that some settings influence it.

jaimecbernardo avatar May 29 '23 11:05 jaimecbernardo