PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

Build 2023 Configuration File for PowerToys

Open ryfu-msft opened this issue 2 years ago • 6 comments

https://github.com/microsoft/winget-cli/issues/2845

ryfu-msft avatar May 24 '23 22:05 ryfu-msft

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (1)

dsc

Previously acknowledged words that are now absent applicationconfiguration Bcl CARRAY Chromakey DANGEROUSLYCOMMITMERELYTODISKCACHE Dct Dds Excep EXCEPINFO Globbing HDR IBitmap IBlock IColor IContext IDecoder IEncoder IMetadata invalidkey IPalette IQuery IReader ISource ISurface LOCKBYTES LOCKTYPE NOOPEN ONLYIFCURRENT ONLYONCE pprop PRGBA PROPERTYNOTFOUND PROPVARIANT pstatstg pstm pvar RGBE runtimeconfig SAFEARRAY Ses sni SRGB STGC STGTY USERDEFINED VARTYPE VERSIONED wsystem YQuantized :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:ryfu-msft/PowerToys.git repository on the buildConfiguration branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/5073919971/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2461) from .github/actions/spell-check/expect.txt and unrecognized words (1)

Dictionary Entries Covers
cspell:win32/src/win32.txt 53509 133
cspell:cpp/src/cpp.txt 30216 132
cspell:python/src/python/python-lib.txt 3873 29
cspell:php/php.txt 2597 21
cspell:node/node.txt 1768 14
cspell:typescript/typescript.txt 1211 13
cspell:java/java.txt 7642 11
cspell:python/src/python/python.txt 453 10
cspell:aws/aws.txt 218 9
cspell:r/src/r.txt 808 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:win32/src/win32.txt
          cspell:cpp/src/cpp.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:java/java.txt
          cspell:python/src/python/python.txt
          cspell:aws/aws.txt
          cspell:r/src/r.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar May 24 '23 22:05 github-actions[bot]

@ryfu-msft it looks like you missed the "s" in ".configurations".

denelon avatar May 25 '23 16:05 denelon

fixed spelling

crutkas avatar May 25 '23 16:05 crutkas

@ryfu-msft it looks like you missed the "s" in ".configurations".

@denelon, where is that mistake?

crutkas avatar May 25 '23 16:05 crutkas

Yes, the convention is ".configurations/configuration.dsc.yaml" as the "default" configuration for a project. Putting the other configurations in the same directory allows for other versions of Visual Studio, and potentially other flavors of configurations.

denelon avatar May 25 '23 16:05 denelon

Yes, the convention is ".configurations/configuration.dsc.yaml" as the "default" configuration for a project. Putting the other configurations in the same directory allows for other versions of Visual Studio, and potentially other flavors of configurations.

I updated the folder name to be ".configurations"

ryfu-msft avatar May 25 '23 17:05 ryfu-msft