PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[PowerRename] Add PowerRename to directory background context menu

Open stefansjfw opened this issue 2 years ago • 1 comments

Summary of the Pull Request

PowerRename now can be triggered by right-clicking the directory background.

Note: Win11 Tier1 context menu will show PowerRename even for directories that can't be renamed (e.g. right-click Downloads dir background) as we can't check that while querying the context menu (selection argument of the API is null in that case). However, internal logic of PowerRename won't allow renaming files/folders that are not renamable. E.g. Try right-clicking Downloads dir background, run PowerRename and try to rename Downloads directory - Apply button will stay disabled.

PR Checklist

  • [x] Closes: #15239
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Install PowerToys
  • Try running PowerRename by right-clicking directory background and ensure that PowerRename works correctly

stefansjfw avatar Mar 03 '23 13:03 stefansjfw

There's some analyzer errors still ;)

jaimecbernardo avatar Mar 03 '23 16:03 jaimecbernardo