PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

Registry Preview: initial drop of source code

Open randyrants opened this issue 2 years ago • 14 comments

Initial collection of source files for Registry Preview, including integration into the PowerToys launcher, settings, and OOBE.

Summary of the Pull Request

This is the initial drop of source for a new applet/utility that allows a user to open a .REG file in a graphically based preview of what it would look like when imported into the Registry. It also gives you a live preview, if you make changes to values in the display text file.

PR Checklist

  • [ ] Closes: N/A, new code
  • [X] Communication: I've discussed this with core contributors already; it can be accepted or rejected as they see fit.
  • [X] Tests: Manual testing has passed
  • [X] Localization: All strings should be in the string table; if there are any missing, it is a bug.
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Binaries are now buildable with the checked in code and as standalone app (no APPXBUNDLE required.)
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

There are two .REG files in the Utils directory that are handy for manual installation (or for adding to an installer.) When imported into the local Registry, it will change the context menu in Windows for .REG files, adding (or removing) a "Preview" menu item. Alternatively, after installing an APPX/APPXBUNDLE, the application can be run from the Start Menu.

Note: exporting an entire top-level branch will generate a large file (~80MB in some cases) which most apps choke, including this one!

Validation Steps Performed

This was tested manually and extensively, using various .REG files found online or exported from the local Registry on many different machines.

randyrants avatar Feb 01 '23 04:02 randyrants

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (3)

Invalidregistry Previewto primatives

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4061284776/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2146) from .github/actions/spell-check/expect.txt and unrecognized words (3)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 122
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
Errors (1)

See the :open_file_folder: files view or the :scroll:action log for details.

:x: Errors Count
:x: check-file-path 1

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 01 '23 05:02 github-actions[bot]

What is the exact use case? Monaco file explorer addon contains a preview definition and I thought peek will get one too.

htcfreek avatar Feb 01 '23 05:02 htcfreek

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (1)

egfile

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4061327461/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2146) from .github/actions/spell-check/expect.txt and unrecognized words (1)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 121
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 01 '23 05:02 github-actions[bot]

What is the exact use case? Monaco file explorer addon contains a preview definition and I thought peek will get one too.

Can't speak to either of the others, but "Previewer" is part of the app: with a REG file open, if you make changes in the text box, the Registry "view" will stay in sync with the text changes, giving you a live and updated preview.

randyrants avatar Feb 01 '23 05:02 randyrants

What is the exact use case? Monaco file explorer addon contains a preview definition and I thought peek will get one too.

Can't speak to either of the others, but "Previewer" is part of the app: with a REG file open, if you make changes in the text box, the Registry "view" will stay in sync with the text changes, giving you a live and updated preview.

~Do we have more information, an existing issue or a spec somewhere?~

I saw it. Can you please reference it in the PR description. Thank you.

htcfreek avatar Feb 01 '23 05:02 htcfreek

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (2)

egfile kxz

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4068597033/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2146) from .github/actions/spell-check/expect.txt and unrecognized words (2)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 121
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 01 '23 20:02 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (4)

APPNAME egfile kxz REGISTRYHEADER

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4130383817/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2146) from .github/actions/spell-check/expect.txt and unrecognized words (4)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 121
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 09 '23 02:02 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (4)

APPNAME egfile kxz REGISTRYHEADER

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4130464158/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2146) from .github/actions/spell-check/expect.txt and unrecognized words (4)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 121
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 09 '23 02:02 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (5)

APPNAME dic egfile kxz REGISTRYHEADER

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath :arrow_right:
Some files were automatically ignored

These sample patterns would exclude them:

^\Qsrc/modules/registrypreview/code-custom.dic\E$

You should consider adding them to:

.github/actions/spell-check/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4130495072/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2146) from .github/actions/spell-check/expect.txt and unrecognized words (5)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 121
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
Errors (2)

See the :open_file_folder: files view or the :scroll:action log for details.

:x: Errors Count
:x: check-file-path 1
:information_source: noisy-file 1

See :x: Event descriptions for more information.

If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 09 '23 02:02 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (2)

egfile REGISTRYHEADER

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath REGISTRYHEADER4 REGISTRYHEADER5 :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4130567817/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2150) from .github/actions/spell-check/expect.txt and unrecognized words (2)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 121
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 09 '23 03:02 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (1)

egfile

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath REGISTRYHEADER4 REGISTRYHEADER5 :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4130599873/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2151) from .github/actions/spell-check/expect.txt and unrecognized words (1)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 121
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 09 '23 03:02 github-actions[bot]

@crutkas As it's passing all of the PR checks, I think this is now ready for review.

randyrants avatar Feb 09 '23 03:02 randyrants

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (1)

REGISTRYPREVIEWEXT

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath REGISTRYHEADER4 REGISTRYHEADER5 :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4172100520/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2152) from .github/actions/spell-check/expect.txt and unrecognized words (1)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 121
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 14 '23 09:02 github-actions[bot]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (2)

privledge Yeet

Previously acknowledged words that are now absent AMF chromaticities depsjsonpath REGISTRYHEADER4 REGISTRYHEADER5 :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4179294051/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2153) from .github/actions/spell-check/expect.txt and unrecognized words (2)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 121
cspell:win32/src/win32.txt 53509 117
cspell:python/src/python/python-lib.txt 3873 31
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Feb 15 '23 00:02 github-actions[bot]

454 files changed look wrong here. Some bad merge probably. Can you try merging the latest main into this PR?

stefansjfw avatar Mar 08 '23 16:03 stefansjfw

454 files changed look wrong here. Some bad merge probably. Can you try merging the latest main into this PR?

I've been pulling in changes from upstream every week or two, since I started the PR, back in January. It very well could be 454 files, given:

  • It started with my new source, for the app itself.
  • Added the integration bits to the launcher UI, including making a settings page
  • Adapted to all of the other changes since January, e.g. requiring all C-style casting to be removed in lieu of static_ or dymanic_cast which had a lot of changes across many files.

I'll do another upsteam fetch in a little bit, recompile and update the PR.

randyrants avatar Mar 08 '23 17:03 randyrants

@stefansjfw Update complete, as of Mar-8 - now up to 468.

I took a look and there's a ton of stuff that came in from upstream:

  • Updates to all the proj files, removing explicit version numbers
  • Casting changes (as called out above)
  • Main added two new projects (MouseZoom and Paste as Plain Text)
  • Other apps took updates (FancyZones looks like it was busy)

If there's something I can do to help ease the changes, lemme know. Up to now, the PR's I've been in have been closed pretty quickly and/or were atomic.

randyrants avatar Mar 08 '23 19:03 randyrants

@stefansjfw Update complete, as of Mar-8 - now up to 468.

I took a look and there's a ton of stuff that came in from upstream:

  • Updates to all the proj files, removing explicit version numbers
  • Casting changes (as called out above)
  • Main added two new projects (MouseZoom and Paste as Plain Text)
  • Other apps took updates (FancyZones looks like it was busy)

If there's something I can do to help ease the changes, lemme know. Up to now, the PR's I've been in have been closed pretty quickly and/or were atomic.

@randyrants The problem was with the target branch for the PR, I changed it to microsoft/main. Now it looks ok, I'll start with the review now

stefansjfw avatar Mar 17 '23 10:03 stefansjfw

/azp run

stefansjfw avatar Mar 17 '23 10:03 stefansjfw

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 17 '23 10:03 azure-pipelines[bot]

I pushed a few fixes for analyzer warnings. Also, I can help with adding RegistryPreview to the installer.

I gave it a quick test. Looks very useful. :) At the moment I see a crash when trying to launch the app from OOBE via "Launch Registry Preview" button.

@niels9001 Can you take a look at the UI here? Thanks! :)

stefansjfw avatar Mar 17 '23 10:03 stefansjfw

@niels9001 Can you take a look at the UI here? Thanks! :)

e.g. in dark mode after clicking in the red area text contrast on the left is not ok as shown below image

stefansjfw avatar Mar 17 '23 10:03 stefansjfw

I've added few more minor cleanups and ARM64 build fix. Also added Registry Preview to the installer. This is ready for the final review now

stefansjfw avatar Mar 17 '23 18:03 stefansjfw

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (5)

clrcompression DCompiler Imc Pkcs wpfgfx

Previously acknowledged words that are now absent Akrotiri Aktobe Andreanof appxpackage Aqtobe Atikokan Atyrau Avanc Bashkortostan Bayan Belarus Bson Burkina Buryatia Cabo Caiguna Choibalsan Chukotka Chuuk Clipperton Cocklebiddy Comoros corewebview Cunha Danmarkshavn datatemplate DONTRESOLVEDLLREFERENCES enumerationoptions Eswatini Eucla Faroe Futuna getancestor getasynckeystate globalassemblycache handlerroutine Heure Hovd inputdev ipreviewhandler Ittoqqortoormiit ivirtualdesktopmanager Ivoire Khakassia Khanty Khovd Kitts Krai Kwango Kwilu kxz Kyrgyzstan Kyzylorda LOADLIBRARYASDATAFILE Luhansk Maarten Macquarie Magadan Mangere Mangystau Mansi Marquesas Mato MCDT MCST menurc Mishkeegogamang Moldova Mongala Mundrabilla MYTZ Navassa navigatetostring Ndombe nonpackaged Noronha Nunavut Nusa oledbcommand oledbconnection Pitcairn Pohnpei Primorsky queryfocus registerhotkey REGISTRYHEADER4 REGISTRYHEADER5 resourcemanager Roamable Rothera Schd secauthz securityoverview shemptyrecyclebina SPACEBAR Srednekolymsk Sul Suri sysinfo Tajikistan Tenggara timezones tostring Transnistria Tshuapa Tuva uapmanifestschema Udmurtia uiauto Ulaanbaatar UMsg Unstub Urville Uvs virtualkey winauto winmsg winuser wtypes WVk XControl Yamalia Zabaykalsky Zonev :arrow_right:
To accept :heavy_check_mark: these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:randyrants/PowerToys.git repository on the feature/regPreview branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/4450574192/attempts/1'
Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2212) from .github/actions/spell-check/expect.txt and unrecognized words (5)

Dictionary Entries Covers
cspell:cpp/src/cpp.txt 30216 119
cspell:win32/src/win32.txt 53509 116
cspell:python/src/python/python-lib.txt 3873 29
cspell:php/php.txt 2597 16
cspell:node/node.txt 1768 13
cspell:typescript/typescript.txt 1211 12
cspell:python/src/python/python.txt 453 10
cspell:java/java.txt 7642 10
cspell:aws/aws.txt 218 8
cspell:python/src/common/extra.txt 741 7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:python/src/python/python.txt
          cspell:java/java.txt
          cspell:aws/aws.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are :exploding_head: false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it, try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

github-actions[bot] avatar Mar 17 '23 18:03 github-actions[bot]

@niels9001 Can you take a look at the UI here? Thanks! :)

e.g. in dark mode after clicking in the red area text contrast on the left is not ok as shown below image

This one is on me: I was trying to get the text to be grey when ReadOnly and was setting it to Colors.Black. Going to find a way to get the theme-based Foreground color for text and will update the source.

randyrants avatar Mar 18 '23 00:03 randyrants

@niels9001 Can you take a look at the UI here? Thanks! :)

e.g. in dark mode after clicking in the red area text contrast on the left is not ok as shown below image

This one is on me: I was trying to get the text to be grey when ReadOnly and was setting it to Colors.Black. Going to find a way to get the theme-based Foreground color for text and will update the source.

Check out the new WinUI 3 Gallery, under Design Guidance => Colors => Text. The TextFillSecondaryBrush is probably what you are looking for!

niels9001 avatar Mar 18 '23 06:03 niels9001

Check out the new WinUI 3 Gallery, under Design Guidance => Colors => Text. The TextFillSecondaryBrush is probably what you are looking for!

It's actually due to new design cues versus what I wanted it to do: I wanted the read only to be visually changed in some way and [currently] ReadOnly TextBoxes are supposed to look the same as editable TextBoxes. If I disable it, it goes grey like I wanted, but then it's also, well, disabled, which I didn't like either. The challenge now is how to load a StaticDynamicResource or DynamicResource via the code and toggle it there. I saw something in a wicked old XAML example but lost it and not even sure if it would make sense to use it.

For now, it's fixed, in at least it supports the grey I wanted and the Light/Dark themes.

randyrants avatar Mar 18 '23 19:03 randyrants

I haven't tested it yet, but what happens when the file isn't properly formatted? And what happens when the version is lower then 5.00?

Aaron-Junker avatar Mar 18 '23 20:03 Aaron-Junker

I haven't tested it yet, but what happens when the file isn't properly formatted? And what happens when the version is lower then 5.00?

As far as coding goes, it looks for 4 and 5, but I have not done a lot of testing on 4 - if memory serves that pre-dates XP and supporting REG files from Windows 2000 or earlier didn't feel like much of a priority.

If a file is not formatted well when you open the file, it should be able to recognize that and throw up an error message. If you're starting a new REG file from scratch, it will allow you to do so, but it "guide" you on how to create a new one. I mean, the Tree and table o' values will try to update as you type, but it will only snap to, once a line is complete: while you're actively typing, it won't be happy until the last " is in the row or you have a dword: or hex: as needed.

More of a Previewer of existing REG files rather than full-on creator of new files.

randyrants avatar Mar 18 '23 21:03 randyrants

Check out the new WinUI 3 Gallery, under Design Guidance => Colors => Text. The TextFillSecondaryBrush is probably what you are looking for!

It's actually due to new design cues versus what I wanted it to do: I wanted the read only to be visually changed in some way and [currently] ReadOnly TextBoxes are supposed to look the same as editable TextBoxes. If I disable it, it goes grey like I wanted, but then it's also, well, disabled, which I didn't like either. The challenge now is how to load a StaticDynamicResource or DynamicResource via the code and toggle it there. I saw something in a wicked old XAML example but lost it and not even sure if it would make sense to use it.

For now, it's fixed, in at least it supports the grey I wanted and the Light/Dark themes.

Yeah.. for UWP/WinUI DynamicResource won't work. You can use {ThemeResource ..} to get brushes that will change with the theme, and {StaticResource ..} for resources that are.. static 😁.

@randyrants Awesome job with new feature! There are a few UI tweaks here and there but I'm happy to tackle those later after this gets in! Same for the icon! Exciting 🚀🚀🚀😁!

niels9001 avatar Mar 20 '23 11:03 niels9001