[Analyzers][CPP] Turn on 4702

[sosssego]

Turn on 4702

unreachable code

PR Checklist

• [x] Continues towards: #xxx
• [x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• [ ] Tests: Added/updated and all pass
• [ ] Localization: All end user facing strings can be localized
• [ ] Dev docs: Added/updated
• [ ] New binaries: Added on the required places
  • [ ] JSON for signing for new binaries
  • [ ] WXS for installer for new binaries and localization folder
  • [ ] YML for CI pipeline for new test projects
  • [ ] YML for signed pipeline
• [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Turn on 4702 - unreachable code Warnings were avoided by removing dead code or suppressing the warning were it was not removed.

Validation Steps Performed

CI

[github-actions[bot]]

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view or the :scroll:action log for details.

Unrecognized words (1)

culinfo

To accept :heavy_check_mark: these unrecognized words as correct, run the following commands

... in a clone of the [email protected]:sosssego/PowerToys.git repository on the analyzers_cpp_turn_on_4702 branch (:information_source: how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.21/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/3577919591/attempts/1'

Available :books: dictionaries could cover words not in the :blue_book: dictionary

This includes both expected items (2136) from .github/actions/spell-check/expect.txt and unrecognized words (1)

Dictionary	Entries	Covers
cspell:cpp/src/cpp.txt	30216	121
cspell:win32/src/win32.txt	53509	117
cspell:python/src/python/python-lib.txt	3873	30
cspell:php/php.txt	2597	16
cspell:node/node.txt	1768	14
cspell:typescript/typescript.txt	1211	12
cspell:java/java.txt	7642	11
cspell:python/src/python/python.txt	453	10
cspell:r/src/r.txt	808	8
cspell:python/src/common/extra.txt	741	7

Consider adding them using (in .github/workflows/spelling2.yml):

      with:
        extra_dictionaries:
          cspell:cpp/src/cpp.txt
          cspell:win32/src/win32.txt
          cspell:python/src/python/python-lib.txt
          cspell:php/php.txt
          cspell:node/node.txt
          cspell:typescript/typescript.txt
          cspell:java/java.txt
          cspell:python/src/python/python.txt
          cspell:r/src/r.txt
          cspell:python/src/common/extra.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''

If the flagged items are :exploding_head: false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it, try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[crutkas]

Any reason to not merge this in?

[davidegiacometti]

@jaimecbernardo my bad here 😅 get_config and set_config changes weren't needed for LLKH support and I think those methods aren't used anymore: that's the reason why everyhing is still working. May be stuffs from the old settings?

[SeraphimaZykova]

May be stuffs from the old settings?

I think so too. get_settings is used to collect settings from all enabled modules and send that json as an ipc message. Since settings app has file watchers to track files, I believe we can remove obsolete code. Maybe I miss something though.