PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[Analyzers][CPP]Turn on warning 4389

Open sosssego opened this issue 2 years ago • 0 comments

Turn on warning 4389

An == or != operation involved signed and unsigned variables. This could result in a loss of data.

PR Checklist

  • [x] Continues towards: #940
  • [x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [x] Tests: Added/updated and all pass - no new tests
  • [x] Localization: All end user facing strings can be localized - no new strings
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

CI

sosssego avatar Nov 14 '22 20:11 sosssego