PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[FancyZones] Don't send shift key to window

Open davidegiacometti opened this issue 3 years ago • 1 comments

Summary of the Pull Request

SHIFT key in git bash is used as modifier for change font size when the window is resized. Prevent FancyZones to send SHIFT key to the window when moved to a zone.

PR Checklist

  • [x] Closes: #18112 #16355
  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • [ ] Tests: Added/updated and all pass
  • [ ] Localization: All end user facing strings can be localized
  • [ ] Dev docs: Added/updated
  • [ ] New binaries: Added on the required places
  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

  • Enable FZ option: hold shift key to activate zones while dragging
  • Open git bash (the one installed with git for windows)
  • Move the window to a zone (test with left and right SHIFT)
  • Font size of the terminal shouldn't change

davidegiacometti avatar Nov 10 '22 21:11 davidegiacometti

@SeraphimaZykova I have just seen that you were assigned to #18112 😄

davidegiacometti avatar Nov 10 '22 21:11 davidegiacometti