PowerToys icon indicating copy to clipboard operation
PowerToys copied to clipboard

[FLS] UI fixes

Open niels9001 opened this issue 2 years ago • 11 comments

  • Updated SettingsControls to 0.7.

  • Removed the wrapping of the End Task button on resizing the window.

  • Icon fixes to fix: #21638

  • [ ] Closes: #21638

  • [ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected

  • [ ] Tests: Added/updated and all pass

  • [ ] Localization: All end user facing strings can be localized

  • [ ] Dev docs: Added/updated

  • [ ] New binaries: Added on the required places

  • [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

niels9001 avatar Nov 04 '22 13:11 niels9001

@niels9001 The margins at the bottom are missing. There is no space between process listview and window border.

htcfreek avatar Nov 04 '22 14:11 htcfreek

@niels9001 , do you know if the glyph mentioned here can be used safely? https://github.com/microsoft/PowerToys/pull/21688#issuecomment-1302412689

jaimecbernardo avatar Nov 04 '22 16:11 jaimecbernardo

@niels9001 , do you know if the glyph mentioned here can be used safely? #21688 (comment)

Yep. Everything above the E500 range can be used: https://learn.microsoft.com/en-us/windows/apps/design/style/segoe-fluent-icons-font#icon-list

niels9001 avatar Nov 04 '22 16:11 niels9001

THanks for opening the PR. There are lots of conflicts, though, and most of them seem to be caused just by changes in white spaces and xaml code indentation on this PR. Were the changes you did just the icon changes or was there something else?

jaimecbernardo avatar Nov 04 '22 16:11 jaimecbernardo

THanks for opening the PR. There are lots of conflicts, though, and most of them seem to be caused just by changes in white spaces and xaml code indentation on this PR. Were the changes you did just the icon changes or was there something else?

I'll resolve the conflicts! Might be good to start adopting a XAML Styler config file so XAML formatting is consistent for everyone?

niels9001 avatar Nov 04 '22 16:11 niels9001

Is that possible? :) (I do XAML manually, though, perhaps there's a linter? )

jaimecbernardo avatar Nov 04 '22 16:11 jaimecbernardo

For reference, these were the changes that made it in recently that are responsible for the conflict: https://github.com/microsoft/PowerToys/pull/21688/files#diff-3bc04002f00a182e5028f397568efda091f8895fa8ae3ee5fe66d7a1e0587e38

jaimecbernardo avatar Nov 04 '22 16:11 jaimecbernardo

Is that possible? :) (I do XAML manually, though, perhaps there's a linter? )

Yep! XAML Styler is a commonly used plugin to format XAML. You can export the (default) config and add it to the root of the project folder. For everyone that has XAML Styler installed, would then use the same formatting.

In Labs, we also have a GH Action that checks on the correct formatting. But that is maybe a bit too much :-)

https://github.com/Xavalon/XamlStyler/wiki/XAML-Styler-Configuration

niels9001 avatar Nov 04 '22 16:11 niels9001

In Labs, we also have a GH Action that checks on the correct formatting. But that is maybe a bit too much :-)

https://github.com/Xavalon/XamlStyler/wiki/XAML-Styler-Configuration

Definitely something to consider, though. These files end up with weird identations / different spaces/tabs usage across projects.

jaimecbernardo avatar Nov 04 '22 16:11 jaimecbernardo

@niels9001 The margins at the bottom are missing. There is no space between process listview and window border.

Are you going to fix this in this PR? Otherwise I will open an issue tomorrow.

htcfreek avatar Nov 05 '22 10:11 htcfreek

@niels9001 The margins at the bottom are missing. There is no space between process listview and window border.

Are you going to fix this in this PR? Otherwise I will open an issue tomorrow.

Fixed!

image

@jaimecbernardo Conflicts should be resolved now!

niels9001 avatar Nov 07 '22 09:11 niels9001

Hi @niels9001 , Thanks a lot for the contribution!

I've added two commits:

  • I've uncommented the text block that was commented but was needed, otherwise it'd be an empty scrollviewer which was causing crashes when trying to render.
  • I've also removed the ItemsPanelTemplate that was added, because that was turning off virtualization and causing crashes when trying to list a big number of items (such as using File Locksmith on the Windows folder running as admin).

PTAL. Are these changes OK? Otherwise, please let's make this PR only about the icon changes and leave other UI fixes for another PR, because we're introducing crashes otherwise on what could go in the hotfix.

jaimecbernardo avatar Nov 07 '22 12:11 jaimecbernardo

Merging so we can include it in the hotfix. Thank you!

jaimecbernardo avatar Nov 07 '22 16:11 jaimecbernardo