Analyzers cpp turn on 4127

[sosssego]

Turn on warning 4127, conditional expression is constant

PR Checklist

• [x] Continues towards: #x940
• [x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• [x] Tests: Added/updated and all pass - no new tests
• [x] Localization: All end user facing strings can be localized - no new strings
• [ ] Dev docs: Added/updated
• [ ] New binaries: Added on the required places
  • [ ] JSON for signing for new binaries
  • [ ] WXS for installer for new binaries and localization folder
  • [ ] YML for CI pipeline for new test projects
  • [ ] YML for signed pipeline
• [ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Turn on warning 4127 and changing 1 if expression to if constexpr

Validation Steps Performed

Unit Tests and CI

[jaimecbernardo]

Hi @sosssego , Build is failing. PTAL?

[jaimecbernardo]

Must've been caused by the merge. It's failing on main as well. Probably due to new code.