Remove unneeded casts

[AZero13]

These casts are not needed and can be safely removed

Summary of the Pull Request

Removed casts that did not need to happen because the variable is already the target type.

PR Checklist

• [x] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• [X] Tests: Added/updated and all pass
• [X] Localization: All end user facing strings can be localized
• [X] Dev docs: Added/updated
• [x] New binaries: Added on the required places
  • [x] JSON for signing for new binaries
  • [x] WXS for installer for new binaries and localization folder
  • [x] YML for CI pipeline for new test projects
  • [x] YML for signed pipeline
• [X] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Tests passed

[crutkas]

How are these getting determined unneeded. Trying to see why this hasn’t been done yet

[AZero13]

Well, for starters, all casts to object are redundant by definition.

[AZero13]

Second, static analysis shows that these casts were superfluous

[crutkas]

My feedback is your suggestion changes but not helping explain from a PR stance why.

What tool are you running or is this an existing flag in the build output?

not saying this is a bad thing, trying to understand how these got flagged.

Trust me, I’m all about getting analysis tools built into the pipelines.

[AZero13]

@crutkas these were Rosyln (the C# compiler) warnings

[crutkas]

@AtariDreams This is larger than casting now.

PRs really need to be scoped

[AZero13]

Done!

[AZero13]

@crutkas Fixed the PR

[AZero13]

These changes were from when changes from different PRs got mixed in.

[AZero13]

@crutkas fixed!

[crutkas]

my main question of how these are getting flagged is still unanswered.

Is this a warning in the build output? A screenshot would be massively helpful for helping us cause right now I do not understand why we are removing the casts

[AZero13]

Some were found manually. Others were by Roslyn warnings

[AZero13]

@crutkas Also, casts to (object) are redundant, and casts to literals are redundant as well

[crutkas]

Once again, I need to understand how we can validate this. We did an aggressive scrub with analyzers a while back and I’m surprised this wasn’t caught as a build warning at a minimum by them

[jaimecbernardo]

Where are these warnings appear exactly? How can we repro this?

[jaimecbernardo]

Closing this, as it's not clear why the change is needed. Please re-open if you feel it's still neccessary.